javascript strict warnings in viewsource.js

VERIFIED FIXED

Status

SeaMonkey
UI Design
P3
normal
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Henrik Gemal, Assigned: bz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

17 years ago
JavaScript strict warning:
chrome://navigator/content/viewsource.js line 20: function viewSource does not 
always return a value

JavaScript strict warning:
chrome://navigator/content/viewsource.js line 58: function viewSource does not 
always return a value

Comment 1

17 years ago
I think I've fixed these...
Assignee: don → disttsc

Comment 2

17 years ago
Warnings should be fixed.  All instances of return in the current function
return either true or false.
(Reporter)

Comment 3

17 years ago
seems to be fixed?

Comment 4

17 years ago
Build: 2001043020

Error: appCore.find is not a function
Source File: chrome://navigator/content/viewsource.js
Line: 59

Comment 5

17 years ago
Mass move to jaggernaut@netscape.com
Assignee: jag → jaggernaut

Comment 6

17 years ago
Jag sez: Hey bbaetz, this is probably fixed, but would you mind checkin it?
Assignee: jaggernaut → bbaetz
wasn't me who worked on view source.

-> bz
Assignee: bbaetz → bzbarsky
That warning was fixed by bug 78419.  We no longer call appCore.find
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

17 years ago
I cant see the warnings with todays build 20010619.
Will reopen if I see them again.

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.