61065 - javascript strict warnings in viewsource.js

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://navigator/content/viewsource.js line 20: function viewSource does not 
always return a value

JavaScript strict warning:
chrome://navigator/content/viewsource.js line 58: function viewSource does not 
always return a value

Comment 1

[Peter "jag" Annema]

I think I've fixed these...

Comment 2

[Mark Olson]

Warnings should be fixed.  All instances of return in the current function
return either true or false.

Comment 3

[Henrik Gemal]

seems to be fixed?

Comment 4

[Alexey Chernyak]

Build: 2001043020

Error: appCore.find is not a function
Source File: chrome://navigator/content/viewsource.js
Line: 59

Comment 5

[Peter "jag" Annema]

Mass move to [e-mail]

Comment 6

[Peter Trudelle]

Jag sez: Hey bbaetz, this is probably fixed, but would you mind checkin it?

Comment 7

[Bradley Baetz (:bbaetz)]

wasn't me who worked on view source.

-> bz

Comment 8

[Boris Zbarsky [:bzbarsky]]

That warning was fixed by bug 78419.  We no longer call appCore.find

Comment 9

[Henrik Gemal]

I cant see the warnings with todays build 20010619.
Will reopen if I see them again.

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);