Closed
Bug 610697
Opened 14 years ago
Closed 14 years ago
Lazy resolution of standard classes changes the shape of Object.prototype
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: bzbarsky, Assigned: brendan)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.93 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
For example, when setting up the Number class, when we JS_DefineFunctions, we use Number.prototype as the parent for the new functions, which makes it a delegate after the first function is defined. Then we add the properties one by one, and do shadowing shape changes when things like toString come through.
|
Assignee | |
Comment 1•14 years ago
|
||
Testing a patch. Care is required to maintain API compatibility for lusers such as XPConnect.
/be
Assignee: general → brendan
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla2.0b8
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #489245 -
Flags: review?(mrbkap)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 489245 [details] [diff] [review]
proposed fix
I like it!
Attachment #489245 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(I'll fix the prottoype typo ;-)
/be
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•14 years ago
|
||
Very nice. I like it.
|
||
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•