Prebrand standard classes with standard methods

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bz, Assigned: brendan)

Tracking

Trunk
mozilla2.0b8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

<brendan> bz: ok, here's what we need (at least -- bhackett's ultimate way is even
          better) to compete on the branding front
<brendan> we prebrand Array.prototype when defining its methods
<brendan> we don't define those lazily
<brendan> we should probably pre-brand for all standard methods
<brendan> that is, make the shape depend on the method's function values
(Assignee)

Comment 1

8 years ago
Created attachment 489233 [details] [diff] [review]
proposed fix

I toyed with removing brand's 2nd and 3rd params but decided to default 'em for now, instead. Could go the other way with a nudge.

/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #489233 - Flags: review?(jorendorff)
(Assignee)

Updated

8 years ago
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla2.0b8
Comment on attachment 489233 [details] [diff] [review]
proposed fix

Please remove the unused parameters. r=me.
Attachment #489233 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

8 years ago
Created attachment 489269 [details] [diff] [review]
patch to commit

Not sure we want a jitstats-based test. It'll be fragile in the face of future work (e.g., bug 593462). This patch passes jsreftests and jit-tests. I dare it to break something! [/me whistles in the dark now.]

/be
Attachment #489233 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Attachment #489269 - Flags: review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/tracemonkey/rev/eab06474c89d

/be
Whiteboard: fixed-in-tracemonkey

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/eab06474c89d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.