610698 - Prebrand standard classes with standard methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

<brendan> bz: ok, here's what we need (at least -- bhackett's ultimate way is even
          better) to compete on the branding front
<brendan> we prebrand Array.prototype when defining its methods
<brendan> we don't define those lazily
<brendan> we should probably pre-brand for all standard methods
<brendan> that is, make the shape depend on the method's function values

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

I toyed with removing brand's 2nd and 3rd params but decided to default 'em for now, instead. Could go the other way with a nudge.

/be

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 489233 [details] [diff] [review]
proposed fix

Please remove the unused parameters. r=me.

Comment 3

[Brendan Eich [:brendan]]

Attachment: patch to commit

Not sure we want a jitstats-based test. It'll be fragile in the face of future work (e.g., bug 593462). This patch passes jsreftests and jit-tests. I dare it to break something! [/me whistles in the dark now.]

/be

Comment 4

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/eab06474c89d

/be

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/eab06474c89d