Closed
Bug 610698
Opened 14 years ago
Closed 14 years ago
Prebrand standard classes with standard methods
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: bzbarsky, Assigned: brendan)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
3.40 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
<brendan> bz: ok, here's what we need (at least -- bhackett's ultimate way is even better) to compete on the branding front <brendan> we prebrand Array.prototype when defining its methods <brendan> we don't define those lazily <brendan> we should probably pre-brand for all standard methods <brendan> that is, make the shape depend on the method's function values
Assignee | ||
Comment 1•14 years ago
|
||
I toyed with removing brand's 2nd and 3rd params but decided to default 'em for now, instead. Could go the other way with a nudge. /be
Assignee | ||
Updated•14 years ago
|
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla2.0b8
Comment 2•14 years ago
|
||
Comment on attachment 489233 [details] [diff] [review] proposed fix Please remove the unused parameters. r=me.
Attachment #489233 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Not sure we want a jitstats-based test. It'll be fragile in the face of future work (e.g., bug 593462). This patch passes jsreftests and jit-tests. I dare it to break something! [/me whistles in the dark now.] /be
Attachment #489233 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Attachment #489269 -
Flags: review+
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/eab06474c89d /be
Whiteboard: fixed-in-tracemonkey
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/eab06474c89d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•