61075 - [MF]No Way To Change Print Range

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Brian Z]

In the latest builds, I cannot select a range of pages to print or print from
selected text.  I really miss these features.  I'm filing this as a bug because
I believe these need to be there.  Thanks!  Keep up the good work!

Comment 1

[Brian Z]

Still an issue in 2000120220.

Comment 2

[Brian Z]

Still Issue in 2000120920

Comment 3

[Fabian Guisset]

Looks like dcone is looking into this.

*** This bug has been marked as a duplicate of 62561 ***

Comment 4

[Brian Z]

Wait.. how can mine 61075 be a dupe of 62561 when mine was reported first and
neither have had any action and both are assigned to the same person?  Shouldn't
it be the other way around?  Sorry, it just makes my record look bad when I have
a bunch of dupes.

Comment 5

[shrirang khanzode]

let's keep your record clean :). reopening tihs one and marking 62561 as a dup 
of this one..

Comment 6

[shrirang khanzode]

confirming bug (sorry for the spam)

Comment 7

[shrirang khanzode]

*** Bug 62561 has been marked as a duplicate of this bug. ***

Comment 8

[Brian Z]

Thanks Fabian.  I really appreciate this.  I've made a few mistakes in the past
about dupes, but trying to see how long I can be dupe free. :)

Comment 9

[Fabian Guisset]

Doesn't make a difference to me.. The only thing I saw was that the person who
is supposed to do it filed the bug, so I thought he would probably like to keep
his own bug. Anyway I understand you want to keep your record clean but Bugzilla
is a bug database, not a game to have the best record as possible, nobody will
blame anyone because they file dups.
Also dcone's bug was NEW and this one was UNCO.
Fabian the humble Bugzilla servitor.

Comment 10

[Brian Z]

Ok, I didn't realize that.  I'm glad to hear no one blames anyone bout dupes.  I
always felt like I wasted someone's time for filing a dupe.  You can do whatever
you like.  Just as long as it get fixed. :)  Thanks!  Keep up the good work u guys.

Comment 11

[Kevin McCluskey (gone)]

Marking mozilla0.8.

Comment 12

[rods (gone)]

I am ready for reviews

Comment 13

[rods (gone)]

fixed

Comment 14

[Brian Z]

In Build 2001012904

Whenever I go to the print dialog, it asks if it should print all 1001 pages.  I
know this is minor, but it should really be cleaned up before mozilla0.7 or
mozilla0.8 for sure.

Comment 15

[shrirang khanzode]

spam : changing qa to sujay (new qa contact for Printing)

Comment 16

[rods (gone)]

Could you attach a screen shot of the dialog, this sounds way bizzare

Comment 17

[Brian Z]

Attachment: Screen Shot :)

Comment 18

[rods (gone)]

At this moment, I am at a complete loss as to what would cause this..... It's 
their dialog, and their code manipulating it. Truly bizzare, give Bill G. a 
call.

Comment 19

[Brian Z]

I'm afraid I don't know who Bill G is.  

Comment 20

[rods (gone)]

As in Bill Gates....

Comment 21

[Kevin McCluskey (gone)]

Rod: We are not clearing out the struct that we pass to ::PrintDlg.
Maybe we should clear out the prntdlg struct before setting the values in it?


NS_IMETHODIMP nsDeviceContextSpecFactoryWin :: CreateDeviceContextSpec

...

 PRINTDLG  prntdlg;

+ memset(&printdlg, 0, sizeof(PRINTDLG);

  prntdlg.lStructSize = sizeof(prntdlg);
  prntdlg.hwndOwner = NULL;               /
  prntdlg.hDevMode = NULL;
  prntdlg.hDevNames = NULL;
  prntdlg.hDC = NULL;
  prntdlg.Flags = PD_ALLPAGES | PD_RETURNIC

Comment 22

[Tobias Burnus]

This (printing page range) was working for me (after the FIXED), but now it
doesn't anymore (2001-02-05-21/Linux). I opend bug 67537 for this problem.

Comment 23

[rods (gone)]

fxied

Comment 24

[Brian Z]

Still Issue (print all 1001 pages) on 2001020820 Win32 Build.  Can't speak for
the other builds.

Comment 25

[rods (gone)]

Index: src/windows/nsDeviceContextSpecFactoryW.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/windows/nsDeviceContextSpecFactoryW.cpp,v
retrieving revision 3.12
diff -u -r3.12 nsDeviceContextSpecFactoryW.cpp
--- nsDeviceContextSpecFactoryW.cpp     2001/02/06 23:03:06     3.12
+++ nsDeviceContextSpecFactoryW.cpp     2001/02/13 23:27:02
@@ -155,10 +155,10 @@
     printService->GetHowToEnableFrameUI(&howToEnableFrameUI);
   }

-  prntdlg.nFromPage           = 1;
-  prntdlg.nToPage             = 1;
-  prntdlg.nMinPage            = 0;
-  prntdlg.nMaxPage            = 1000;
+  prntdlg.nFromPage           = 0xFFFF;
+  prntdlg.nToPage             = 0xFFFF;
+  prntdlg.nMinPage            = 1;
+  prntdlg.nMaxPage            = 0xFFFF;
   prntdlg.nCopies             = 1;
   prntdlg.hInstance           = hInstance;
   prntdlg.lCustData           = (DWORD)howToEnableFrameUI;
@@ -171,7 +171,7 @@


   if(PR_TRUE == aQuiet){
-    prntdlg.Flags = PD_RETURNDEFAULT;
+    prntdlg.Flags = PD_ALLPAGES | PD_RETURNDEFAULT;
   }

   BOOL res = ::PrintDlg(&prntdlg);

Comment 26

[Marc Attinasi]

Cool. sr=attinasi

Comment 27

[dcone (gone)]

r=dcone

Comment 28

[rods (gone)]

I couldn't find any documentation explaining on this specifically (classic 
Microsoft)

But it appears if you set nMinPage to 0, and then nFromPage, nTomPage, & 
nMaxPage to 0xFFFF the dialog behaves the way you want it to for "All Pages" and 
"Page Range" 

Plus, it appears you need to pre-set the flags to both "PD_ALLPAGES | 
PD_RETURNDEFAULT" in order for the dialog to not appear and have the 
"::PrintDlg(&prntdlg);" call return.

Comment 29

[sujay]

Brian, is this working for you now? please mark verified-fixed...thanks!

Comment 30

[Brian Z]

Yep, works great. :)  Doesn't display total number of pages though.  Maybe I'll
open another bug requesting that.

Comment 31

[rods (gone)]

You can open a bug for that, but it will be futured or marked invalid. It's 
a chicken and egg problem. You can't display the number of pages without laying 
the document out. You can't lay the document out until you know what driver you 
are using or the desired page size (which happens to be on the same dialog), 
which is needed so you know how big the page will etc.

IE doesn't do it and in fact I would imagine that none of the browsers do it for 
that very same reason. Word processors can do it because the document you are 
typing in already has a formated page size. In a browser, what you look at is 
laid out completely different from how it goes to the printer.