610785 - Can't open downloaded .apk file

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

steps:

- download a .apk file from the web
- download completes, shows up in download manager
- I press "open"
- nothing happens

the apk should open and offer to install the app

Comment 1

[Aakash Desai [:aakashd]]

What .apk file are you downloading where this happens, Madhava?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Brad - can you see if something is not working in the platform?

Comment 3

[Madhava Enros [:madhava]]

(In reply to comment #1)
> What .apk file are you downloading where this happens, Madhava?

It was fennec, but I don't remember where from now -- possibly a custom build to look at some feature under development.

Comment 4

[Aakash Desai [:aakashd]]

Yeah, I see this when doing the following

1. Go to people.mozilla.com/~blassey/builds
2. Long tap on the "fennec.apk" link and click on Save link"
3. After the download is finished, go to the download manager

Actual Results:
The "open" button is disabled

Expected Results:
The "open" button is enabled

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: patch

We disable the "Open" button when we can't find a MIME type using getTypeFromFile.  This patch fixes this by adding ".apk" to the list of recognized file extensions.

(Currently, we do auto-open the file if the server sends the correct MIME type, although the "Open" button is still disabled if you return the download manager later.)

Comment 6

[Benjamin Smedberg]

Comment on attachment 494524 [details] [diff] [review]
patch

I don't own this code, thank goodness.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 494524 [details] [diff] [review]
patch

Yeah, this seems fine.

Comment 8

[Matt Brubeck (:mbrubeck)]

Attachment: patch for checkin

Comment 9

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/a7692d5dd29b

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101203 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 11

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=15021 created to regression test this bug.

Comment 13

[Aljoscha Rittner]

I've the a similar problem with a HTC Desire Android 2.2 rooted with Leedroid and the final Fennec version

I can't open downloaded PDF files - the [Open] button is grayed out (e.g. with the Save as PDF function).