Closed
Bug 610901
Opened 14 years ago
Closed 14 years ago
need to explicitly construct/destruct JITScript
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
3.35 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
JITScript is calloc'd but not in-place constructed. At the moment, this is good enough for js::Vector to work but njn had a problem when he tried to do something non-trivial in the constructor. The JITScript also doesn't seem to be destructed, which could be responsible for the Talos max-memory-usage regression this morning.
|
||
Updated•14 years ago
|
blocking2.0: --- → betaN+
Only equality ICs use JITScript::execPools right now, but typed arrays will as well.
Blocks: 594247
|
Assignee | |
Comment 2•14 years ago
|
||
AFAICS, there is only one place where JITScripts are allocated/deallocated.
Attachment #489525 -
Flags: review?(dvander)
|
|
||
Updated•14 years ago
|
Attachment #489525 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/001472f3c9af
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/001472f3c9af
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•