need to explicitly construct/destruct JITScript

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

JITScript is calloc'd but not in-place constructed.  At the moment, this is good enough for js::Vector to work but njn had a problem when he tried to do something non-trivial in the constructor.  The JITScript also doesn't seem to be destructed, which could be responsible for the Talos max-memory-usage regression this morning.
blocking2.0: --- → betaN+
Only equality ICs use JITScript::execPools right now, but typed arrays will as well.
Blocks: 594247
Posted patch patchSplinter Review
AFAICS, there is only one place where JITScripts are allocated/deallocated.
Attachment #489525 - Flags: review?(dvander)
Attachment #489525 - Flags: review?(dvander) → review+
http://hg.mozilla.org/tracemonkey/rev/001472f3c9af
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/001472f3c9af
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.