We initially placed the "Setup Sync" and "Sync Now" commands on the right side of the Firefox menu, at the bottom. The idea was partly to draw more attention to this command by isolating it, and also to group it with the items on the right side that all represent the types of data that are actually being sync'd (bookmarks, history, preferences, etc.) However, it just ends up looking kind of strange and out of place over there. Let's move it to the left side and place it after Full Screen and before Exit (it's important that it remains close to Exit since a lot of users are going to want to sync before the close).
On a somewhat related note, we might want to consider putting "Tabs From Other Computers" in a somewhat more accessible location on Windows than just the "All Tabs" drop down. Would that be a candidate for the Firefox menu as well?
With 29% of users accessing the tab overflow menu, I think that's going to be discoverable enough (placing it in the Firefox only doubles the chance of discovery to 59%). Also it's nice to group all of the tab features together into a single place.
actually I was filtered on beginner data, either way the value are about the same when you look at all levels: https://heatmap.mozillalabs.com
Created attachment 496532 [details] [diff] [review] patch
We should move Full Screen up to a different group. Grouping it with Sync and Exit doesn't seem to make sense.
>We should move Full Screen up to a different group. Grouping it with Sync and >Exit doesn't seem to make sense. Yep I agree. Note that if we add the zoom controls those would end up being grouped with full screen: Web Developer -------------- Zoom [slider control] Full Screen -------------- Sync Now Exit
Created attachment 496666 [details] [diff] [review] patch v2 Added menuseparator.
Since we don't have the zoom control yet, should we move Full Screen somewhere else for the time being? Without the zoom item, it seems that we'd get too many separators for too few items again.
Comment on attachment 496666 [details] [diff] [review] patch v2 See previous comment. Please don't assume the zoom item to exist when implementing this.
Alex, what do you think I should do until the zoom control exists? No separator? That would look like this: Web Developer -------------- Full Screen Sync Now Exit Or, we could move Full Screen somewhere else like Dão suggested in comment 8.
This bug is being tracked as part of this set: http://areweprettyyet.com/4/syncPromotion/
Created attachment 503517 [details] [diff] [review] patch v3 I got rid of the menuseparator to match Alex's mockup.
Comment on attachment 503517 [details] [diff] [review] patch v3 Well, I can't complain about the code. FWIW, the grouping doesn't seem to make sense.
Since we don't have the zoom control, we either have to have too many separators (comment #8), or groups that don't really make that much sense. I mostly indifferent, with perhaps a slight preference to limiting the number of separators for the time being and having the last group not make that much sense.
http://hg.mozilla.org/mozilla-central/rev/c53984e562b8 I added a comment to bug 592147 about adding the menuseparator once the zoom controls are added.