610951 - Failure to build in PluginInstanceChild.cpp with -std=gnu++0x

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Avoid c++0x compilers to fail on narrowing conversions inside {} in PluginInstanceChild.cpp

This is the error message I get when building with g++ -std=gnu++0x:
../../../dom/plugins/PluginInstanceChild.cpp:2644: error: narrowing conversion of 'rect.nsIntRect::y' from 'PRInt32' to 'uint16_t' inside { }
../../../dom/plugins/PluginInstanceChild.cpp:2644: error: narrowing conversion of 'rect.nsIntRect::x' from 'PRInt32' to 'uint16_t' inside { }
../../../dom/plugins/PluginInstanceChild.cpp:2644: error: narrowing conversion of 'rect.nsIntRect::YMost()' from 'PRInt32' to 'uint16_t' inside { }
../../../dom/plugins/PluginInstanceChild.cpp:2644: error: narrowing conversion of 'rect.nsIntRect::XMost()' from 'PRInt32' to 'uint16_t' inside { }

Casting to uint16_t is enough to make this build and on par with what other compilers non complaining would do, but it could be worth checking if there can't be any overflows there. (though I'd expect these values to be on-screen positions and lengths, which means a uint16_t is probably good enough)

Comment 1

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/0f17e5f1eb01