61110 - javascript strict warnings in tinderbox

Status: VERIFIED FIXED

(Webtools Graveyard :: Tinderbox, defect, P3)

Description

[David Gardiner]

Mozilla displays the following strict javascript warnings when viewing the 
tinderbox page:

JavaScript strict warning:
http://tinderbox.mozilla.org/SeaMonkey/ line 87: redeclaration of var l

JavaScript strict warning:
http://tinderbox.mozilla.org/SeaMonkey/ line 122: redeclaration of var l

JavaScript strict warning:
http://tinderbox.mozilla.org/SeaMonkey/ line 176: assignment to undeclared 
variable notes

JavaScript strict warning:
http://tinderbox.mozilla.org/SeaMonkey/ line 177: assignment to undeclared 
variable builds

JavaScript strict warning:
http://tinderbox.mozilla.org/SeaMonkey/ line 185: assignment to undeclared 
variable buildtree

I think it would be pretty easy to make these warnings go away.

-dave

Comment 1

[Henrik Gemal]

Attachment: Diff to fix warnings

Comment 2

[Dave Miller [:justdave]]

This looks like a duplicate of bug 58436, which also has a patch attached.  I'm 

not sure I want to outright mark it as a duplicate though because the patches 

aren't exactly the same...

Comment 3

[David Gardiner]

This is a bug/patch for tinderbox.

Bug 58436 looks like it is related to javascript in Bugzilla.

Unless i'm mistaken, then these are indeed different bugs.
-dave

Comment 4

[Dave Miller [:justdave]]

heh, oops.  That'll teach me to make comments this late at night :-)

Definately related though.  Same bug, two different programs.

Comment 5

[Dawn Endico]

reassigning to mcafee to review patch

Comment 6

[Chris McAfee]

r=mcafee.  Does it work?  I can check in if needed.

Comment 7

[David Gardiner]

it should work.. i don't have my own tinderbox to test it, but the patch is 
harmless in that it declares variables with var that weren't, and stops 
redeclaring variables that already were declared.

-dave

Comment 8

[Henrik Gemal]

we have a patch....!

Comment 9

[Chris McAfee]

fix checked in.  Sorry it took so long.
Updated tinderbox.mozilla.org.

Comment 10

[Henrik Gemal]

verified fixed...