611396 - StartupCache.cpp has 3 "warning: unused variable 'rv'"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

Attachment: trivial fix

StartupCache.cpp currently has this build-warning-spam:

{
../../mozilla/startupcache/StartupCache.cpp: In member function 'virtual nsresult mozilla::scache::StartupCacheDebugOutputStream::WriteObject(nsISupports*, PRBool)':
../../mozilla/startupcache/StartupCache.cpp:487: warning: unused variable 'rv'
../../mozilla/startupcache/StartupCache.cpp: In member function 'virtual nsresult mozilla::scache::StartupCacheDebugOutputStream::WriteSingleRefObject(nsISupports*)':
../../mozilla/startupcache/StartupCache.cpp:501: warning: unused variable 'rv'
../../mozilla/startupcache/StartupCache.cpp: In member function 'virtual nsresult mozilla::scache::StartupCacheDebugOutputStream::WriteCompoundObject(nsISupports*, const nsIID&, PRBool)':
../../mozilla/startupcache/StartupCache.cpp:516: warning: unused variable 'rv'
}

It's just from three completely-unused "nsresult rv;" lines.

Attached patch fixes this.

Comment 1

[[e-mail]]

Comment on attachment 489861 [details] [diff] [review]
trivial fix

If it builds, ship it.

Comment 2

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

Comment on attachment 489861 [details] [diff] [review]
trivial fix

Yay, thanks! (yes, it does build)

Need approval to land, though -- requesting approval.

Justification: trivial patch, no risk.  As noted in comment 0, this just removes three absolutely-unnecessary lines of the form:
> nsresult rv;

Comment 3

[Daniel Holbert [:dholbert][mostly away until Oct 6]]

http://hg.mozilla.org/mozilla-central/rev/d48a0e23feec