Closed
Bug 611396
Opened 13 years ago
Closed 13 years ago
StartupCache.cpp has 3 "warning: unused variable 'rv'"
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: dholbert, Unassigned)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
1.87 KB,
patch
|
dwitte
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
StartupCache.cpp currently has this build-warning-spam: { ../../mozilla/startupcache/StartupCache.cpp: In member function 'virtual nsresult mozilla::scache::StartupCacheDebugOutputStream::WriteObject(nsISupports*, PRBool)': ../../mozilla/startupcache/StartupCache.cpp:487: warning: unused variable 'rv' ../../mozilla/startupcache/StartupCache.cpp: In member function 'virtual nsresult mozilla::scache::StartupCacheDebugOutputStream::WriteSingleRefObject(nsISupports*)': ../../mozilla/startupcache/StartupCache.cpp:501: warning: unused variable 'rv' ../../mozilla/startupcache/StartupCache.cpp: In member function 'virtual nsresult mozilla::scache::StartupCacheDebugOutputStream::WriteCompoundObject(nsISupports*, const nsIID&, PRBool)': ../../mozilla/startupcache/StartupCache.cpp:516: warning: unused variable 'rv' } It's just from three completely-unused "nsresult rv;" lines. Attached patch fixes this.
Attachment #489861 -
Flags: review?
Reporter | ||
Updated•13 years ago
|
Attachment #489861 -
Flags: review? → review?(dwitte)
Comment 1•13 years ago
|
||
Comment on attachment 489861 [details] [diff] [review] trivial fix If it builds, ship it.
Attachment #489861 -
Flags: review?(dwitte) → review+
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 489861 [details] [diff] [review] trivial fix Yay, thanks! (yes, it does build) Need approval to land, though -- requesting approval. Justification: trivial patch, no risk. As noted in comment 0, this just removes three absolutely-unnecessary lines of the form: > nsresult rv;
Attachment #489861 -
Flags: approval2.0?
Updated•13 years ago
|
Attachment #489861 -
Flags: approval2.0? → approval2.0+
Reporter | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d48a0e23feec
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•