Buildbot JSON needs logURL field

RESOLVED FIXED

Status

Release Engineering
General
P4
normal
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: mstange, Assigned: catlee)

Tracking

({buildapi})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildapi][json][logs])

(Reporter)

Description

7 years ago
Getting the URL of the log that's uploaded for a build is trickier than it should be. At the moment it's possible for most builds by connecting the packageUrl, build_url, builddir and buildnumber fields, as demonstrated here:
http://hg.mozilla.org/users/dbaron_mozilla.com/buildbot-json-tools/file/28b24c910790/filter-buildbot-json.py#l47

However, that neither works for Talos runs (no builddir field) nor for busted builds (no packageUrl or build_url field).
Summary: Bulidbot JSON needs logURL field → Buildbot JSON needs logURL field
Priority: -- → P4
(Assignee)

Comment 1

7 years ago
The problem right now is that the log is uploaded asynchronously after the build is completed.  We could pre-compute what the log url _should_ be, but if the actual log transfer fails for some reason the logUrl property wouldn't be correct.  This might be a decent intermediate step to take though.

If we change how we're doing log uploading from a asynchronous status plugin that's triggered after the build is finished to a master-side step that runs as the last step, we will be able to set this property before the build is finished, so it would show up in the list of build properties as well.
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> The problem right now is that the log is uploaded asynchronously after the
> build is completed.  We could pre-compute what the log url _should_ be, but if
> the actual log transfer fails for some reason the logUrl property wouldn't be
> correct.  This might be a decent intermediate step to take though.

Yes, that would be a big step forward.

Not knowing the log filename for Talos runs and failed builds is the biggest obstacle to a Tinderbox-free TBPL at the moment.
(Assignee)

Updated

7 years ago
Assignee: nobody → catlee
Priority: P4 → P2
(Assignee)

Updated

7 years ago
Whiteboard: [buildapi][json]
(Assignee)

Updated

7 years ago
Priority: P2 → P4
(Reporter)

Comment 3

7 years ago
This is not urgent anymore. The Run._log function at http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/tip/dataimport/import-buildbot-data.py seems to work pretty well.
(Assignee)

Updated

7 years ago
Assignee: catlee → nobody
(In reply to Chris AtLee [:catlee] from comment #1)
> We could pre-compute what the log url _should_ be, but
> if the actual log transfer fails for some reason the logUrl property
> wouldn't be correct.

It would, however, be exactly as good as tbpl's current reverse-engineering. It also would have saved you from the backout of bug 671450, and would save me the comment I'm trying to write in bug 685299, which is a truly awful "reverse engineering of tbpl's reverse engineering of buildbot's upload path rules so that another chunk of buildbot can upload where tbpl expects it to."
(Assignee)

Updated

6 years ago
Whiteboard: [buildapi][json] → [buildapi][json][logs]
(Assignee)

Updated

6 years ago
Depends on: 713846
(Assignee)

Comment 5

6 years ago
this property will be called 'log_url'
Assignee: nobody → catlee
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

5 years ago
Keywords: buildapi
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.