Closed
Bug 611639
Opened 14 years ago
Closed 14 years ago
NS_ProxyRelease does not work for RefPtrs
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file)
|
1.46 KB,
patch
|
Details | Diff | Splinter Review |
We are missing an overload for RefPtrs, that means that trying to use it with RefPtrs does not release on the requested thread, but on the current one. My patch in bug 599973 hit this when trying to release an instance of nsFaviconService on the main-thread.
|
Assignee | |
Comment 1•14 years ago
|
||
oh and actually that means we crash on dereference when the release happens in the async runnable since it has already been release.
|
|
Assignee | |
Comment 2•14 years ago
|
||
I'm not sure if NS_HIDDEN_ is really still needed nowadays, but I mostly did a 1:1 copy of the COMPtr overload
Attachment #490077 -
Flags: review?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #490077 -
Flags: review? → review?(benjamin)
|
||
Comment 3•14 years ago
|
||
Need this to fix a blocker (I suppose we could work around this be implementing it ourselves, but that's just silly).
blocking2.0: --- → betaN+
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 490077 [details] [diff] [review] patch v1.0 I just talked with shaver. He says r=shaver but we need to template it if we get a third one.
Attachment #490077 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/projects/places/rev/d65c65ef13a4
Whiteboard: [fixed-in-places]
|
|
Assignee | |
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d65c65ef13a4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•