611735 - Deprecated function showPopup() used in datetimepickers.xml

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Martin Schröder [:mschroeder]]

One occurrence of the deprecated function showPopup() has been missed in bug 588869 and should be replaced accordingly (http://mxr.mozilla.org/comm-central/source/calendar/resources/content/datetimepickers/datetimepickers.xml#400).

Comment 1

[Edmund Wong (:ewong)]

Attachment: Removed the last vestige of showPopup() in datetimepickers.xml

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 512151 [details] [diff] [review]
Removed the last vestige of showPopup() in datetimepickers.xml

r=philipp

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a23f326c9da2>
-> FIXED

Comment 4

[Decathlon]

It seems this fix causes a malfunctioning in the datepickers.
When clicking on a button (previous/next/today) or selecting a different month or year from one of the button in the header of the minimonth, it jumps on the left top corner of the dialog window where the datepicker is in (at least on Win7).
When I try to restore the showPopup() instead of openPopup() in the code line changed by the patch, the behavior becomes as it should be.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Strange stuff. I guess we could revert this for now, since the function has not been removed. Could you check that all parameters are correct and see if it works with openPopup somehow?

Comment 6

[Decathlon]

I've tried this:

aEvent.target.parentNode.openPopup(aEvent.target);

and seems working, but I don't know exactly how openPopup() works.

Comment 7

[Edmund Wong (:ewong)]

Attachment: Updated patch to fix a problem with the datetimepickers.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 540698 [details] [diff] [review]
Updated patch to fix a problem with the datetimepickers.

r=philipp

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/fbe40875d241>
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/7dfeaf1aabd9>

-> FIXED