Deprecated function showPopup() used in datetimepickers.xml

RESOLVED FIXED in 1.0b4

Status

defect
--
minor
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: martinschroeder, Assigned: ewong)

Tracking

Trunk
1.0b4

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments)

One occurrence of the deprecated function showPopup() has been missed in bug 588869 and should be replaced accordingly (http://mxr.mozilla.org/comm-central/source/calendar/resources/content/datetimepickers/datetimepickers.xml#400).
Whiteboard: [good first bug]
Assignee

Updated

9 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Comment on attachment 512151 [details] [diff] [review]
Removed the last vestige of showPopup() in datetimepickers.xml

r=philipp
Attachment #512151 - Flags: review?(mschroeder) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a23f326c9da2>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk

Comment 4

8 years ago
It seems this fix causes a malfunctioning in the datepickers.
When clicking on a button (previous/next/today) or selecting a different month or year from one of the button in the header of the minimonth, it jumps on the left top corner of the dialog window where the datepicker is in (at least on Win7).
When I try to restore the showPopup() instead of openPopup() in the code line changed by the patch, the behavior becomes as it should be.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Strange stuff. I guess we could revert this for now, since the function has not been removed. Could you check that all parameters are correct and see if it works with openPopup somehow?

Comment 6

8 years ago
I've tried this:

aEvent.target.parentNode.openPopup(aEvent.target);

and seems working, but I don't know exactly how openPopup() works.
Assignee

Updated

8 years ago
Status: REOPENED → ASSIGNED
Comment on attachment 540698 [details] [diff] [review]
Updated patch to fix a problem with the datetimepickers.

r=philipp
Attachment #540698 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/fbe40875d241>
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/7dfeaf1aabd9>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.