611759 - [Pinstripe] Remove '-moz-appearance: treeheadersortarrow' from listbox.css/tree.css

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Stefan [:stefanh]]

Attachment: Remove rules and obsolete icons

Looking at tree.css and listbox.css we use "-moz-appearance: treeheadercell;" on treecol, treecolpicker and listheader. Then we use "-moz-appearance: treeheadersortarrow;" on .treecol-sortdirection and .listheader-sortdirection. Then we also use some ancient gif images for the sortDirection's that we never see.

Looking at the widget code, treeheadersortarrow doesn't seem to do anything - instead it looks like the sort direction arrows are done by treeheadercell (NS_THEME_TREEVIEW_HEADER_CELL):



1826     case NS_THEME_TREEVIEW_HEADER_CELL: {
1827       TreeSortDirection sortDirection = GetTreeSortDirection(aFrame);
1828       DrawButton(cgContext, kThemeListHeaderButton, macRect, PR_FALSE,
1829                  sortDirection == eTreeSortDirection_Natural ? kThemeButtonOff : kThemeButtonOn,
1830                  sortDirection == eTreeSortDirection_Ascending ?
1831                  kThemeAdornmentHeaderButtonSortUp : kThemeAdornmentNone, eventState, aFrame);
1832     }
.
.
.
1843     case NS_THEME_TREEVIEW_HEADER:
1844       // do nothing, taken care of by individual header cells
1845     case NS_THEME_TREEVIEW_HEADER_SORTARROW:
1846       // do nothing, taken care of by treeview header

Comment 1

[Stefan [:stefanh]]

http://hg.mozilla.org/mozilla-central/rev/6c1a5f4eb350