611967 - [RTL] Firefox 4 Windows theme mirror the text for the 'Forward' button

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tomer Cohen :tomer]

Attachment: screenshot

Steps to reprodce: 
A. Start RTL build of Firefox in a new, empty profile.
B. Right click on the toolbar, customize toolbar, and add text captions to buttons.

Actual result: 
The text for the "Forward" button appears mirrored, and is not easily readable.

Issue is still reproducible when icons and leaving only text captions. On the attached screenshot, text should be "קדימה" and not as appeared on the screenshot.

This issue was reported to by one of our community members, and I was able to reproduce on Windows 7 VM. Issue is not reproducible currently on Linux builds.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 490363 [details] [diff] [review]
patch

Note that we could flip just the icon rather than the whole button in icons+text mode, but in icons mode with large icons we'd need to flip the whole button again (for the SVG mask), so in the end this would complicate the code.

Comment 3

[(no longer active)]

Comment on attachment 490363 [details] [diff] [review]
patch

Why is this not an issue for the back button?

Comment 4

[Dão Gottwald [:dao]]

The back button doesn't have an SVG mask, so we only flip the icon.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/b83e4f6f7207