Closed
Bug 611984
Opened 14 years ago
Closed 14 years ago
Compilation failure on mingw in modules/libjar after bug 598416 landing.
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(2 files)
|
481 bytes,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
|
723 bytes,
patch
|
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
mingw doesn't support SEH exception handling, so we shouldn't try to use it there.
|
Assignee | |
Updated•14 years ago
|
Attachment #490379 -
Flags: review?(tglek)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
|
|
Assignee | |
Updated•14 years ago
|
Attachment #490379 -
Attachment is patch: true
|
||
Comment 1•14 years ago
|
||
Comment on attachment 490379 [details] [diff] [review]
fix v1.0
So when windows generates EXCEPTION_IN_PAGE_ERROR(which it seems prone to), mingw apps just crash with no hope of recovery?
Please change the define to something like
#if defined(XP_WIN) && defined(_MSC_VER)
Attachment #490379 -
Flags: review?(tglek) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Comment on attachment 490379 [details] [diff] [review]
> fix v1.0
>
> So when windows generates EXCEPTION_IN_PAGE_ERROR(which it seems prone to),
> mingw apps just crash with no hope of recovery?
We can't really do much more. win64 SEH exception is planned for GCC 4.6 and win32 for GCC 4.7. Once there will be support, I'm planning to go back to enable such cases again, but it will be more generic probelem that will have to be solved in whole sources.
> Please change the define to something like
>
> #if defined(XP_WIN) && defined(_MSC_VER)
I will change it. Thanks for the review.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #490432 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #490432 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•