Closed
Bug 612018
Opened 14 years ago
Closed 14 years ago
"ASSERTION: frame must not be dirty" and non-blinking caret
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: jruderman, Assigned: ehsan.akhgari)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files)
|
360 bytes,
text/html
|
Details | |
|
2.89 KB,
text/plain
|
Details | |
|
1.80 KB,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: frame must not be dirty: '!NS_SUBTREE_DIRTY(this)', file layout/generic/nsFrame.cpp, line 909
Guessing that like bug 609821, this is a regression from bug 389321.
|
Reporter | |
Comment 1•14 years ago
|
||
|
Assignee | |
Comment 2•14 years ago
|
||
Flush layout before messing with the caret in SetFocusInner.
Attachment #490659 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #490659 -
Flags: approval2.0?
Attachment #490659 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing]
|
||
Comment 3•14 years ago
|
||
You could also remove the redundant "if (doc)".
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b0d153229290
(In reply to comment #3)
> You could also remove the redundant "if (doc)".
Sorry, saw this to late. :(
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > You could also remove the redundant "if (doc)".
>
> Sorry, saw this to late. :(
Well, I got around to it in another push:
http://hg.mozilla.org/mozilla-central/rev/ef83567ee8d8
You need to log in
before you can comment on or make changes to this bug.
Description
•