Closed Bug 612018 Opened 9 years ago Closed 9 years ago

"ASSERTION: frame must not be dirty" and non-blinking caret

Categories

(Core :: Editor, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: jruderman, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

###!!! ASSERTION: frame must not be dirty: '!NS_SUBTREE_DIRTY(this)', file layout/generic/nsFrame.cpp, line 909

Guessing that like bug 609821, this is a regression from bug 389321.
Attached file stack trace
Attached patch Patch (v1)Splinter Review
Flush layout before messing with the caret in SetFocusInner.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #490659 - Flags: review?(roc)
Attachment #490659 - Flags: approval2.0?
Whiteboard: [needs landing]
You could also remove the redundant "if (doc)".
http://hg.mozilla.org/mozilla-central/rev/b0d153229290

(In reply to comment #3)
> You could also remove the redundant "if (doc)".

Sorry, saw this to late.  :(
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
(In reply to comment #4)
> (In reply to comment #3)
> > You could also remove the redundant "if (doc)".
> 
> Sorry, saw this to late.  :(

Well, I got around to it in another push:

http://hg.mozilla.org/mozilla-central/rev/ef83567ee8d8
You need to log in before you can comment on or make changes to this bug.