612167 - Build error Cannot open include file: 'nsSetDllDirectory.h' during Fennec desktop build

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Honza Bambas (:mayhemer)]

Attachment: v1

Need to export that header.

Fennec desktop build is broken w/o it after bug 610556 has landed.

nsBrowserApp.cpp
c:/mozilla-build/python25/python.exe -O d:/mozilla/mozilla-central/build/cl.py cl -FonsBrowserApp.obj -c -D_HAS_EXCEPTIONS=0 -I../../dist/stl_wrappers  -DOSTYPE=\"WINNT5.1\" -DOSARCH=WINNT -DGRE_MILESTONE=2.0b8pre -DGRE_BUILDID=20101114204731 -DAPP_BUILDID=20101114215407 -DAPP_NAME=fennec -DAPP_VERSION=4.0b3pre -DMOZ_UPDATER=1  -DMOZILLA_OFFICIAL -DMOZ_SOURCE_STAMP="df1c79eb047e" -DMOZ_SOURCE_REPO="http://hg.mozilla.org/mobile-browser" -I/d/mozilla/mozilla-central/toolkit/xre -I/d/mozilla/mozilla-central/mobile/app -I. -I../../dist/include -I../../dist/include/nsprpub  -Id:/mozilla/mozilla-central/_obj-mobile-debug/dist/include/nspr -Id:/mozilla/mozilla-central/_obj-mobile-debug/dist/include/nss         -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800  -DDEBUG -D_DEBUG -DTRACING -Zi -MDd           -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT /d/mozilla/mozilla-central/mobile/app/nsBrowserApp.cpp
nsBrowserApp.cpp
d:\mozilla\mozilla-central\toolkit\xre\nsWindowsWMain.cpp(10) : fatal error C1083: Cannot open include file: 'nsSetDllDirectory.h': No such file or directory
make[4]: *** [nsBrowserApp.obj] Error 2
make[4]: Leaving directory `/d/mozilla/mozilla-central/_obj-mobile-debug/mobile/app'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/d/mozilla/mozilla-central/_obj-mobile-debug/mobile'
make[2]: *** [libs_tier_app] Error 2
make[2]: Leaving directory `/d/mozilla/mozilla-central/_obj-mobile-debug'
make[1]: *** [tier_app] Error 2
make[1]: Leaving directory `/d/mozilla/mozilla-central/_obj-mobile-debug'
make: *** [default] Error 2
make: Leaving directory `/d/mozilla/mozilla-central/_obj-mobile-debug'

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 490477 [details] [diff] [review]
v1

Fennec should just add xpcom/base to LOCAL_INCLUDES.

Comment 2

[Honza Bambas (:mayhemer)]

(In reply to comment #1)
> Comment on attachment 490477 [details] [diff] [review]
> v1
> 
> Fennec should just add xpcom/base to LOCAL_INCLUDES.

You mean to include from <srcroot>/xpcom/base directly?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, just like you're doing for toolkit/xre
http://mxr.mozilla.org/mobile-browser/source/app/Makefile.in#55

Comment 4

[Honza Bambas (:mayhemer)]

Ah, ok, will update the patch soon.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: local include fix

Fixes the Mobile local includes to match desktop Firefox.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/673c3b2feb98

Comment 7

[Honza Bambas (:mayhemer)]

Thanks Mark.

Comment 8

[Anna (Waverley)]

Can someone please verify this bug?

Comment 9

[Honza Bambas (:mayhemer)]

Verified, I build desktop Fennec quit often.

Comment 10

[Dão Gottwald [:dao]]

bugspam