612169 - Switch to construct/destroy model for widget

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

See bug 596053.

Comment 1

[Drew Willcoxon :adw]

Attachment: patch

Like my context-menu patch (bug 612016 comment 1), destroy() is idempotent.

In addition to the test and doc, this patch updates various parts of the SDK that use widgets.  Several trailing whitespace removals too.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 490481 [details] [diff] [review]
patch

Let's see who wants it more!

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 490481 [details] [diff] [review]
patch


>@@ -161,21 +161,8 @@ Represents a widget object.
>     Optional text to show when the user's mouse hovers over the widget.  If not
>     given, the `label` is used.
> </api>
>+<api name="destroy">
>+@method
>+  Removes the widget from the widget bar.
> </api>

Can you also update the docs to explicitly say that widgets are added to the browser UI when instantiated, if they don't already?

Also, please send a message to the list about this change.

r=me, very reluctantly... because it rots the heck out my e10s patch ;)

Comment 4

[Drew Willcoxon :adw]

patches:
https://github.com/mozilla/addon-sdk/commit/4812eafc5388f24702ae235a2e4628b477443b7c
https://github.com/mozilla/addon-sdk/commit/a6bc252cb070ff0608df445ed0691ec111a07f19

merge:
https://github.com/mozilla/addon-sdk/commit/36d9ec2e5cca8ea3b9c9e9cd9cc5664c650c9445

Myk posted about the construct/destroy change in general here:

http://groups.google.com/group/mozilla-labs-jetpack/browse_thread/thread/92fe6afa5407f4e3/e3d0dc3c45920df5

Once all the other changes have landed, we should probably post a big follow-up message (or several smaller messages) describing them, with examples, etc.