Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Move Find In Page, Share Page, and Save As PDF to app menu on Android

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: mbrubeck, Assigned: mfinkle)

Tracking

(4 keywords)

Trunk
Firefox 6
All
Android
icon, polish, uiwanted, ux-discovery
Dependency tree / graph
Bug Flags:
in-testsuite ?
in-litmus ?

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Find In Page, Share Page, and Save As PDF are currently located in the Site Options menu in Fennec.

On Android, the application menu (bug 606565) is a better place for these commands.  Logically, they are page actions (not "site options").  Practically, I expect they will be more discoverable if they are in the main app menu.  And finally, it will be more consistent with the default Android browser, and with the Android platform in general.

The new menu structure on Android would be:

App Menu:
Find In Page, Share Page, Site Options, Preferences, Add-ons, Downloads

Site Options:
identity panel, Forget Password, Reset Permissions, Add Search Engine

Adding these two options (Find, Share) would bring the number of app menu items to six.  This is maximum that can appear in the main Android-style menu.  If we implement Save As PDF on Android (bug 595919), or if add-ons extend the app menu (see my "Full Screen" add-on for an example), then we will definitely need to implement the overflow UI (bug 610784).

One downside of this proposal is that we cannot use the same UI on Maemo (which lacks a system "Menu" button).  This would complicate documentation and code maintenance.  However, we already deal with difference in menu structure between desktop platforms, so I don't think this is a deal-breaker.
(Reporter)

Updated

7 years ago
OS: All → Android
I'm not convinced moving these commands to the App menu is a good idea. The Site menu is a good place for page actions. The App menu is a good place for application actions.
Flags: in-testsuite?
Flags: in-litmus?(ayanshah62)
(In reply to comment #1)
> I'm not convinced moving these commands to the App menu is a good idea. The
> Site menu is a good place for page actions. The App menu is a good place for
> application actions.

And now I have changed my mind. Need UX input too.
Whiteboard: [fennec-4.1?]
Cross platform is one issue here, but feels like it's going to be less of a concern for the next couple of releases; other platforms seem to increasingly have some standard "app menu" mechanism.

I think the division mbrubeck suggests makes sense, esp for things that are more browser actions like Find in Page and Save as PDF.  Share Page still straddles that line in my mind, but it's true that Android users will look in the Android menu first, and that's top-tier functionality.

This gives us some room back in the Site Menu for giving more granular access to things like the permissions you've given a site, and for the identity relationship you're managing with a site.

It would be great to avoid going to overflow, by default, in the Android menu, if we can think of some way to avoid that.
(In reply to comment #3)

> It would be great to avoid going to overflow, by default, in the Android menu,
> if we can think of some way to avoid that.

We plan to add a "More" mechanism to the Android menu
(In reply to comment #4)
> (In reply to comment #3)
> 
> > It would be great to avoid going to overflow, by default, in the Android menu,
> > if we can think of some way to avoid that.
> 
> We plan to add a "More" mechanism to the Android menu

Well, yes -- we'd need one, especially given that add-ons will extend the set no matter what we do.  If we had it by default, maybe it's "Downloads" that would get demoted - need to think about this a bit more.
Keywords: uiwanted
(Reporter)

Comment 6

6 years ago
If we do this, we'll need Android menu icons for Find In Page, Share Page, and Save As PDF.
Assignee: nobody → mbrubeck
Depends on: 610784
Summary: Move "Find In Page" and "Share Page" to app menu on Android → Move Find In Page, Share Page, and Save As PDF to app menu on Android
(In reply to comment #6)
> If we do this, we'll need Android menu icons for Find In Page, Share Page, and
> Save As PDF.

If we decide to use icons for the "More" overflow. I don't think we have room for those to all appear on the main app menu.
Keywords: icon
(Assignee)

Updated

6 years ago
tracking-fennec: --- → 6+
Whiteboard: [fennec-4.1?]
(Reporter)

Updated

6 years ago
Blocks: 659987
Created attachment 535661 [details]
App menu icons

Attached icon sets, one for Gingerbread, one for Froyo :)
(Reporter)

Comment 9

6 years ago
I think we still need an icon for "Save as PDF."
(Reporter)

Comment 10

6 years ago
(In reply to comment #9)
> I think we still need an icon for "Save as PDF."

...or we can just put it last, so it will be in the "More" menu and does not need an icon.
(In reply to comment #10)
> (In reply to comment #9)
> > I think we still need an icon for "Save as PDF."
> 
> ...or we can just put it last, so it will be in the "More" menu and does not
> need an icon.

That is exactly what the current patch does. Just in case, I reuse the "download" image for it in CSS.
Created attachment 535709 [details] [diff] [review]
patch

This patch does the simple stuff (adds the menu items to the overflow list) and some hard stuff (move the overflow list into it's own container)

* appmenu-*.png images have been updated in froyo and gingerbread
* 2 new appmenu-*.png images for findinpage and share were added to froyo and gingerbread
* AppMenuOverflow JS class was aded to AppMenu.js to handle the new overflow list
* XUL was added to browser.xul to host the overflow list
* appmenu-overflow items were added to browser.css in froyo and gingerbread to style the overflow list
* bumped the row height for popup menus, context menus and appmenu overflow items to be more inline with Android on froyo and gingerbread
Assignee: mbrubeck → mark.finkle
Attachment #535709 - Flags: review?(mbrubeck)
(Assignee)

Updated

6 years ago
Attachment #535709 - Flags: review?(wjohnston)
(Reporter)

Comment 13

6 years ago
Comment on attachment 535709 [details] [diff] [review]
patch

Review of attachment 535709 [details] [diff] [review]:
-----------------------------------------------------------------

mobile/chrome/tests/browser_appmenu.js needs to be updated too.

::: mobile/themes/core/browser.css
@@ +1094,5 @@
>    -moz-border-left-colors: white;
>    border-style: solid;
>    border-width: @border_width_tiny@ !important;
> +  height: @touch_button_xlarge@;
> +  min-height: @touch_button_xlarge@;

This causes misalignment with the :hover:active background image for these elements in the Froyo theme.  (The easiest solution is to get a new background image that matches the larger size.)
Attachment #535709 - Flags: review?(mbrubeck) → review+
Comment on attachment 535709 [details] [diff] [review]
patch

>+    let overflow = this.overflow;
>+    let listbox = overflow.lastChild;
>+    while (listbox.firstChild)
>+      listbox.removeChild(listbox.firstChild);

Any reason not to get the actual list here?
Attachment #535709 - Flags: review?(wjohnston) → review+
Created attachment 535901 [details] [diff] [review]
patch for tests

This patch fixes the appmenu tests:
* adds .hidden where needed
* removes some menu items so we start with the more button hidden (adds the menu items back at end of test)
* uses the new element for the more menu list
Attachment #535901 - Flags: review?(wjohnston)
Created attachment 535902 [details] [diff] [review]
patch for tests v2

This patch also fixes the browser_find tests. Instead of always assuming Find in Page is in the Site Menu, the test now uses the App Menu, which is available on all platforms. Find in Page is not on the Site Menu for Android.
Attachment #535901 - Attachment is obsolete: true
Attachment #535902 - Flags: review?(wjohnston)
Attachment #535901 - Flags: review?(wjohnston)
Comment on attachment 535902 [details] [diff] [review]
patch for tests v2

Review of attachment 535902 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535902 - Flags: review?(wjohnston) → review+
Comment on attachment 535709 [details] [diff] [review]
patch

low-risk, android only, been baking on trunk for a while and really helps with android integration
Attachment #535709 - Flags: approval-mozilla-aurora?
Attachment #535709 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
pushed:
http://hg.mozilla.org/mozilla-central/rev/aa1c53df226f
http://hg.mozilla.org/mozilla-central/rev/cd0fb5103ee9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Target Milestone: --- → Firefox 7
noting that I had to push a followup for missing files:
http://hg.mozilla.org/mozilla-central/rev/aad412c52fab
http://hg.mozilla.org/releases/mozilla-aurora/rev/283bad4b1eca
status-firefox6: --- → fixed
(Reporter)

Updated

6 years ago
Target Milestone: Firefox 7 → Firefox 6
(Reporter)

Updated

6 years ago
Depends on: 663116
Verified : 
Mozilla/5.0 (Android; Linux armv71; rv6.0a2) Gecko/20110623 Firefox/6.0a2 Fennec/6.0a2
Device: Thunderbolt
OS: Android 2.2

Mozilla/5.0 (Android; Linux armv71; rv6.0a2) Gecko/20110623 Firefox/6.0a2 Fennec/6.0a2
Device: HTC Flyer
OS: Android 2.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.