612235 - "Forget about this site" makes Library a zombie.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Andreea Pod]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre

I get no reaction from "Forget about this site", if triggered from Library's context menu. More, after calling this feature, the applet containing history list is blocked. 

Reproducible: Always

Steps to Reproduce:
1.Open History > Show All History from the main menu.
2.Right click and chose "Forget about this site" for an entry.
Actual Results:  
No entry is deleted and the Library window locks.

Expected Results:  
All the related pages of that site should be deleted and you could navigate through the remained pages with no problem.

Note: tested only against win7. regression range wanted?

Comment 1

[Maniac Vlad Florin (:vladmaniac)]

This is confirmed for 

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre

Comment 2

[Alice0775 White]

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/4d99a78ddae4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101111 Firefox/4.0b8pre ID:20101112131930
Fails:
http://hg.mozilla.org/mozilla-central/rev/1911a8629c39
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101112 Firefox/4.0b8pre ID:20101112143830
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4d99a78ddae4&tochange=1911a8629c39

Comment 3

[Marco Bonardo [:mak]]

taking for investigation.

Comment 4

[Marco Bonardo [:mak]]

probably a blocker if the Library hangs.

Comment 5

[Andreea Pod]

I also found that Library > Bookmarks can be blocked if chose "Forget about this site" for an item from Bookmarks Toolbar > Most Visited.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.0

This fixes both the above issues for me, it was nested batches calls.

Before going to central I'll push to try just to check that my assertion is safely handled (it should be much better than the old bogus warning).

Comment 7

[Marco Bonardo [:mak]]

fwiw, it's not really a hang, it's just that we stop handling selection events!

Comment 8

[juan becerra [:juanb]]

I believe this is in litmus (test case 11225).

Comment 9

[Marco Bonardo [:mak]]

the NS_ABORT is still hitting a case in browser_library_left_pane_commands.js I'll try to debug it.

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1.1

I'm removing the abort because it is triggering in absolutely common and valid situations. Tracking all batching levels from the source would require much deeper changes that are not worth the gain (that would just be having a correct abort) now.

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/bc41cecec7bd

Comment 12

[Andreea Pod]

This is still happening, build id:

Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110109 Firefox/4.0b9pre

Comment 13

[Marco Bonardo [:mak]]

(In reply to comment #12)
> This is still happening, build id:
> 
> Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110109
> Firefox/4.0b9pre

if that's the case that must be a new bug, so please file a new bug including steps to reproduce starting from a clean profile.