612268 - session restore does not flush sidebar or menubar state immediately

Status: NEW

Description

[Teodosia Pop]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre

After session restore the menu bar and the bookmark toolbar are hidden. 

Reproducible: Always

Steps to Reproduce:
1.Start Firefox with a fresh profile
2.Open 5 tabs with different web pages in each and make sure you have a page with Silverlight content (http://www.silverlight.net/showcase/)
3.Bring up the menu bar and the bookmark toolbar.
4.Resize the window to any size and position somewhere on the screen.
5.Repeat steps 2 and 3 for two new windows (use different web pages, window sizes, and window positions for each window)
6.Start downloading an Ubuntu image from http://www.ubuntu.com/getubuntu/download
7.Kill Firefox using the instructions below.
8.Start Firefox

Actual Results:  
The menu bar and the bookmark toolbar are no longer displayed. 
The window size and position are not preserved. 

Expected Results:  
The session should be restored to as it was before it was killed.

After the session restore, the Silverlight plugin does not load. The content of page http://www.silverlight.net/showcase/ is not displayed.

Comment 1

[Dietrich Ayala (:dietrich)]

Paul is this session restore or a xul persistence bug?

Comment 2

[Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)]

(In reply to comment #1)
> Paul is this session restore or a xul persistence bug?

AFAIK we should be restoring that. But changing those attributes wouldn't initiate a save or mark a window dirty, so if those get changed before something else marks a window dirty (opening a new tab, navigating, etc) and before the next save, those changes would get lost.

Teodosia - If you quit normally after doing all of these steps, is everything restored as expected?

Comment 3

[juan becerra [:juanb]]

A normal quit doesn't display the Silverlight content after restarting. I have to shift-reload in order for the content to show.

Comment 4

[Teodosia Pop]

After normal quit (Save and Quit) everything is as expected.

Comment 5

[Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)]

(In reply to comment #3)
> A normal quit doesn't display the Silverlight content after restarting. I have
> to shift-reload in order for the content to show.

So that's a bit strange. But that sounds more like a cache issue. We tend to restore from cache if it's available.

(In reply to comment #4)
> After normal quit (Save and Quit) everything is as expected.

With this, I'm inclined to say "oh well". We do pretty well for crash recovery, but I don't expect it to be perfect.

We could probably make it such that we always update window position/features when we save instead of only for dirty windows. If I have time or somebody wants to pick it up, I would say we would take it, but I wouldn't block on it.