612271 - Cursor jumps back to the end of the previous line after pressing enter at the end of a textarea managed by the jQuery autoResize plugin

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Shawn Collier]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101115 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101115 Firefox/4.0b8pre

Pretty sure this happened after the new JS backend landed a while back, since I didn't have this problem with Firefox 3.6.

Essentially, what happens is that once the textarea automatically resizes, every time you press Enter to make a new line, Minefield will jump up to the previous line instead of staying on the new line.

Reproducible: Always

Steps to Reproduce:
1. After loading the webpage, click on the end of the text in the textbox.
2. Press Enter.
3. After pressing Enter a few times, the problem should reveal itself.
Actual Results:  
Cursor "jumps" back up to the previous line instead of staying on the new line.

Expected Results:  
Cursor should stay on the new line.

Comment 1

[Maniac Vlad Florin (:vladmaniac)]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre 

I can confirm this also on yesterday's nightly.

Comment 2

[Alice0775 White]

This also happens on ubuntu8.04.

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b829cf5debce&tochange=178f26e21cfc

Comment 3

[Dietrich Ayala (:dietrich)]

Ehsan, maybe bug 597331?

Comment 4

[David Dahl :ddahl]

foojkdjkfdjkfjkdjfkdjkfjkdjfkjdkfjkdjkfjdkfjk

Comment 5

[(no longer active)]

(In reply to comment #3)
> Ehsan, maybe bug 597331?

Yep, that's definitely the culprit.

(In reply to comment #4)
> foojkdjkfdjkfjkdjfkdjkfjkdjfkjdkfjkdjkfjdkfjk

I'm sorry David, but I can't really parse that!  ;-)

Comment 6

[(no longer active)]

This is a minimized test case for <http://james.padolsey.com/javascript/jquery-plugin-autoresize/>

Comment 7

[(no longer active)]

Actually, this is really a regression from bug 240933 <http://hg.mozilla.org/mozilla-central/rev/c3236786510b>; it's only being exposed by bug 597331.

The root cause is that nsTextControlFrame::OffsetToDOMPoint violates the invariant that the selection must be set on the trailing BR node if it's at the end of the text.

Comment 8

[(no longer active)]

Attachment: Patch (v1)

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/1655a76ea188