612283 - XP FirefoxButton should look like an XP button

Status: RESOLVED WONTFIX

(Firefox :: Theme, enhancement)

Description

[Antwan]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b7) Gecko/20100101 Firefox/4.0b7
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b7) Gecko/20100101 Firefox/4.0b7

According the mockups, the Firefox button should be like this on WinXP : 
https://wiki.mozilla.org/Firefox/4.0_Windows_Theme_Mockups#Large_Button_Mode_with_Firefox_Button

So far, the button just look like a Vista/7 button, i.e. a button from Aero theme : http://img543.imageshack.us/img543/4846/firefoxmenu.png

Hacking title bar is not usual on XP applications, therefore it should be done wisely.
IMO the aim of the mockup is not only to show the button should be enlargen, it is to focus on the fact that it should _fit_ the OS, i.e. the Firefox button should just look like the close/minimize/maximize buttons and should not touch the top edge of the title bar (quick example on attachment 483125 [details] )
By extension, the button should also be different on Win XP w/ classic theme, and on WinVista without aero.

If UI developpements still continue in this direction, there will be inconsistencies on other systems than Win7, because currently the button just fits this OS.

Reproducible: Always

Steps to Reproduce:
1. Open Firefox on Windows XP
2. Look at Firefox button
Actual Results:  
It looks like an Aero button.

Expected Results:  
It should look like a Luna button, or something more integrated than a simple copy of the Aero theme.

This bug should block bug 556174 : [meta][project] Firefox Button

Comment 1

[Jim Mathies [:jimm]]

I believe this is fixed in nightlies.

Comment 2

[Antwan]

Attachment: Glitches of FirefoxButton on WinXP on 101016

The button has been enlargen.

However it is still an aero-style button (glued to the top).
Anyway, changing the look of this button is not my decision.

However there are still glitches on XP:

- There is a blue 1px unlickable line above the button
- The button is not grayed when inactive
- The blue bar does not expand under the tabs

(see attachment)

Comment 3

[Peter Henkel [:Terepin]]

(In reply to comment #1)
> I believe this is fixed in nightlies.

On the contrary, it's a lot bigger (read uglier). It is nowhere near to FXB on those mockups.

Comment 4

[Dão Gottwald [:dao]]

The Firefox button is going to be removed in bug 863753.