Closed Bug 612305 Opened 9 years ago Closed 9 years ago

tabbrowser.xml is only interested in resize events for the chrome window, should ignore those for content windows

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 4.0b8

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patchSplinter Review
No description provided.
Attachment #490588 - Flags: review?(gavin.sharp)
I guess we could actually drop the width != this.mTabstripWidth check at that point...
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #490588 - Attachment is obsolete: true
Attachment #490589 - Flags: review?(gavin.sharp)
Attachment #490588 - Flags: review?(gavin.sharp)
Bug 343370 comment 3 lists two cases where the width checking might help:
- ""resize" event is also fired when the chrome layout is chnaged" (not sure what this is about, it might be bogus)
- only the window height changes

Perhaps we should keep it?
(In reply to comment #3)
> Bug 343370 comment 3 lists two cases where the width checking might help:
> - ""resize" event is also fired when the chrome layout is chnaged" (not sure
> what this is about, it might be bogus)

That's the content window's resize event, i.e. this bug.

> - only the window height changes

That's a valid point.
Attachment #490588 - Flags: review?(gavin.sharp)
Attachment #490588 - Attachment is obsolete: false
Attachment #490589 - Attachment is obsolete: true
Attachment #490589 - Flags: review?(gavin.sharp)
(In reply to comment #4)
> That's the content window's resize event, i.e. this bug.

Oh, I see - I thought he was talking about it firing on the chrome window for reasons other than it actually being resized, but your interpretation makes more sense.
Attachment #490588 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/b0ef3f1aabb2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Verified fixed based on check-in.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.