612305 - tabbrowser.xml is only interested in resize events for the chrome window, should ignore those for content windows

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

I guess we could actually drop the width != this.mTabstripWidth check at that point...

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Bug 343370 comment 3 lists two cases where the width checking might help:
- ""resize" event is also fired when the chrome layout is chnaged" (not sure what this is about, it might be bogus)
- only the window height changes

Perhaps we should keep it?

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Bug 343370 comment 3 lists two cases where the width checking might help:
> - ""resize" event is also fired when the chrome layout is chnaged" (not sure
> what this is about, it might be bogus)

That's the content window's resize event, i.e. this bug.

> - only the window height changes

That's a valid point.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> That's the content window's resize event, i.e. this bug.

Oh, I see - I thought he was talking about it firing on the chrome window for reasons other than it actually being resized, but your interpretation makes more sense.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/b0ef3f1aabb2

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on check-in.