Closed
Bug 612320
Opened 15 years ago
Closed 13 years ago
remove useless viewport changes
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
In bug 607774 we added at the last minute viewport changes before doing the glClear() call, but it seems that that's useless: glClear() ignores the viewport.
Attachment #490610 -
Flags: review?(vladimir)
mm, you're right, glClear does -- but it does not ignore the scissor rectangle. So I think this needs to be a PushScissorRect etc. instead.
|
Assignee | |
Comment 2•15 years ago
|
||
We're already disabling the scissor test here.
realGLboolean wasScissorTestEnabled = mContext->gl->fIsEnabled(LOCAL_GL_SCISSOR_TEST);
mContext->gl->fDisable(LOCAL_GL_SCISSOR_TEST);
Attachment #490610 -
Flags: review?(vladimir) → review+
|
||
Comment 3•14 years ago
|
||
Looks like this can be landed, but wasn't.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 490610 [details] [diff] [review]
remove useless viewport change
Forgot to land this... putting r?me so I can't forget it again
Attachment #490610 -
Flags: review?(bjacob)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #490610 -
Flags: review?(bjacob)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Assignee: nobody → bjacob
Target Milestone: --- → mozilla12
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•