remove useless viewport changes

RESOLVED FIXED in mozilla12

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In bug 607774 we added at the last minute viewport changes before doing the glClear() call, but it seems that that's useless: glClear() ignores the viewport.
Attachment #490610 - Flags: review?(vladimir)
mm, you're right, glClear does -- but it does not ignore the scissor rectangle.  So I think this needs to be a PushScissorRect etc. instead.
We're already disabling the scissor test here.

        realGLboolean wasScissorTestEnabled = mContext->gl->fIsEnabled(LOCAL_GL_SCISSOR_TEST);
        mContext->gl->fDisable(LOCAL_GL_SCISSOR_TEST);
Looks like this can be landed, but wasn't.
Comment on attachment 490610 [details] [diff] [review]
remove useless viewport change

Forgot to land this... putting r?me so I can't forget it again
Attachment #490610 - Flags: review?(bjacob)
Attachment #490610 - Flags: review?(bjacob)
http://hg.mozilla.org/integration/mozilla-inbound/rev/71d5f079acca
Assignee: nobody → bjacob
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/71d5f079acca
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.