Last Comment Bug 612320 - remove useless viewport changes
: remove useless viewport changes
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla12
Assigned To: Benoit Jacob [:bjacob] (mostly away)
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2010-11-15 10:44 PST by Benoit Jacob [:bjacob] (mostly away)
Modified: 2012-01-16 20:01 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

remove useless viewport change (1.62 KB, patch)
2010-11-15 10:44 PST, Benoit Jacob [:bjacob] (mostly away)
vladimir: review+
Details | Diff | Splinter Review

Description User image Benoit Jacob [:bjacob] (mostly away) 2010-11-15 10:44:11 PST
Created attachment 490610 [details] [diff] [review]
remove useless viewport change

In bug 607774 we added at the last minute viewport changes before doing the glClear() call, but it seems that that's useless: glClear() ignores the viewport.
Comment 1 User image Vladimir Vukicevic [:vlad] [:vladv] 2010-11-15 11:25:52 PST
mm, you're right, glClear does -- but it does not ignore the scissor rectangle.  So I think this needs to be a PushScissorRect etc. instead.
Comment 2 User image Benoit Jacob [:bjacob] (mostly away) 2010-11-15 11:42:06 PST
We're already disabling the scissor test here.

        realGLboolean wasScissorTestEnabled = mContext->gl->fIsEnabled(LOCAL_GL_SCISSOR_TEST);
Comment 3 User image Doug Sherk (:drs) (inactive) 2011-10-07 17:53:19 PDT
Looks like this can be landed, but wasn't.
Comment 4 User image Benoit Jacob [:bjacob] (mostly away) 2012-01-13 14:42:41 PST
Comment on attachment 490610 [details] [diff] [review]
remove useless viewport change

Forgot to land this... putting r?me so I can't forget it again
Comment 5 User image Benoit Jacob [:bjacob] (mostly away) 2012-01-16 14:10:01 PST
Comment 6 User image Justin Wood (:Callek) [away until Feb 27] 2012-01-16 20:01:21 PST

Note You need to log in before you can comment on or make changes to this bug.