remove useless viewport changes

RESOLVED FIXED in mozilla12

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 490610 [details] [diff] [review]
remove useless viewport change

In bug 607774 we added at the last minute viewport changes before doing the glClear() call, but it seems that that's useless: glClear() ignores the viewport.
Attachment #490610 - Flags: review?(vladimir)
mm, you're right, glClear does -- but it does not ignore the scissor rectangle.  So I think this needs to be a PushScissorRect etc. instead.
(Assignee)

Comment 2

7 years ago
We're already disabling the scissor test here.

        realGLboolean wasScissorTestEnabled = mContext->gl->fIsEnabled(LOCAL_GL_SCISSOR_TEST);
        mContext->gl->fDisable(LOCAL_GL_SCISSOR_TEST);
Attachment #490610 - Flags: review?(vladimir) → review+
Looks like this can be landed, but wasn't.
(Assignee)

Comment 4

5 years ago
Comment on attachment 490610 [details] [diff] [review]
remove useless viewport change

Forgot to land this... putting r?me so I can't forget it again
Attachment #490610 - Flags: review?(bjacob)
(Assignee)

Updated

5 years ago
Attachment #490610 - Flags: review?(bjacob)
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/71d5f079acca
Assignee: nobody → bjacob
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/71d5f079acca
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.