612320 - remove useless viewport changes

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: remove useless viewport change

In bug 607774 we added at the last minute viewport changes before doing the glClear() call, but it seems that that's useless: glClear() ignores the viewport.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

mm, you're right, glClear does -- but it does not ignore the scissor rectangle.  So I think this needs to be a PushScissorRect etc. instead.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

We're already disabling the scissor test here.

        realGLboolean wasScissorTestEnabled = mContext->gl->fIsEnabled(LOCAL_GL_SCISSOR_TEST);
        mContext->gl->fDisable(LOCAL_GL_SCISSOR_TEST);

Comment 3

[Doug Sherk (:drs) (inactive)]

Looks like this can be landed, but wasn't.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 490610 [details] [diff] [review]
remove useless viewport change

Forgot to land this... putting r?me so I can't forget it again

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/71d5f079acca

Comment 6

[Justin Wood (:Callek)]

https://hg.mozilla.org/mozilla-central/rev/71d5f079acca