Closed Bug 612336 Opened 9 years ago Closed 9 years ago

fix a number of webgl tests

Categories

(Core :: Canvas: WebGL, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(8 files)

Here's a pile of small fixes for various webgl tests.
the underlying issue is that we do fake-attrib-0 handling, but when we try to restore, we didn't have the correct "default" values for the original attrib 0 since it wasn't modified.  So VertexAttribPointer raised a GL error, because size was invalid.  This sets the WebGLVertexAttribData object's initial params to the GL defaults.
Attachment #490626 - Flags: review?
this (unfortunately large) patch renames the context interface from nsICanvasRenderingContextWebGL to nsIDOMWebGLRenderingContext, so that it ends up as "WebGLRenderingContext" in content.  The entire patch is a file rename and a bunch of search and replace.
Attachment #490627 - Flags: review?(jst)
glClear needs to check that only COLOR, DEPTH, STENCIL bits can be specified and nothing else.
Attachment #490628 - Flags: review?(bjacob)
per ES 2.0, we can only have one shader of each type attached to a program, unlike desktop which can have an arbitrary number.  Enforce this here.
Attachment #490630 - Flags: review?(bjacob)
this is kind of a silly fix.  The spec and man pages state that if /both/ format and type are invalid, then it's an INVALID_OPERATION.  But if one is valid and the other invalid, then it's an INVALID_ENUM.  *shrug*
Attachment #490632 - Flags: review?(bjacob)
Attachment #490626 - Flags: review? → review?(bjacob)
Attachment #490625 - Flags: review?(bjacob) → review+
Attachment #490628 - Flags: review?(bjacob) → review+
Attachment #490630 - Flags: review?(bjacob) → review+
Attachment #490631 - Flags: review?(bjacob) → review+
Attachment #490632 - Flags: review?(bjacob) → review+
Attachment #490626 - Flags: review?(bjacob) → review+
Comment on attachment 490627 [details] [diff] [review]
fix the webgl context type

r=me
Attachment #490627 - Flags: review?(jst) → review+
blocking2.0: --- → betaN+
You need to log in before you can comment on or make changes to this bug.