612429 - Can't build debug on MaeMo/ARM due to inclusion of SSE2 asm

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Brian Crowder]

c++ -o yuv_row_posix.o -c  -fvisibility=hidden -D_IMPL_NS_GFX -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux  -I/home/crowder/mobilla/gfx/ycbcr -I. -I../../dist/include -I../../dist/include/nsprpub  -I/home/crowder/mobilla/objdir-mmo-dbg/dist/include/nspr -I/home/crowder/mobilla/objdir-mmo-dbg/dist/include/nss       -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-strict-aliasing -pthread -pipe  -DDEBUG -D_DEBUG -DTRACING -g   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/yuv_row_posix.pp /home/crowder/mobilla/gfx/ycbcr/yuv_row_posix.cpp
{standard input}: Assembler messages:
{standard input}:894: Error: bad instruction `emms'
{standard input}:1147: Error: bad instruction `emms'
make[5]: *** [yuv_convert.o] Error 1
make[5]: Leaving directory `/home/crowder/mobilla/objdir-mmo-dbg/gfx/ycbcr'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/home/crowder/mobilla/objdir-mmo-dbg/gfx'
make[3]: *** [libs_tier_platform] Error 2
make[3]: Leaving directory `/home/crowder/mobilla/objdir-mmo-dbg'
make[2]: *** [tier_platform] Error 2
make[2]: Leaving directory `/home/crowder/mobilla/objdir-mmo-dbg'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/crowder/mobilla/objdir-mmo-dbg'
make: *** [build] Error 2

Comment 1

[cajbir (:cajbir)]

Looks to be a regression of bug 564901. I must have missed a change we made when upgrading to the latest YCbCr code in bug 583138.

Comment 2

[Brian Crowder]

Attachment: updated version of the old patch

Comment 3

[Brian Crowder]

Attachment: This updates convert.patch as well

Comment 4

[cajbir (:cajbir)]

Comment on attachment 490754 [details] [diff] [review]
This updates convert.patch as well

Asking for approval to land so we can fix maemo bustage.

Comment 5

[Brian Crowder]

Comment on attachment 490754 [details] [diff] [review]
This updates convert.patch as well

Woops, building in the wrong tree and I led myself to believe this was fixed...  new patch shortly

Comment 6

[Brian Crowder]

Attachment: new

This gets me further along, but I am having another build issue later.  Chris:  can you handle generating the patch fix for this?  I'm not able to generate a patch that resembles yours closely, and so I'm ending up with a convert.patch that includes dozens of changes instead of just one.

Comment 8

[cajbir (:cajbir)]

Attachment: Fix

Brian's fix with change to .patch file as requested. I've carried reviewed forward and re-requested approval.

Comment 9

[cajbir (:cajbir)]

http://hg.mozilla.org/mozilla-central/rev/5f0d24418e7e