61244 - [NAMESPACE]CSS files with no default stylesheet are causing styling of elements in unknown namespaces

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, defect, P3)

Description

[hand]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0; COM+ 1.0.2204)
BuildID:    2000112620

Namespaces which Mozilla aren't suppose to recognise have styles.

Reproducible: Always
Steps to Reproduce:
no steps to reproduce

Actual Results:  Because unrecognized namespaces have styles, some elements in 
arbitrary namespaces such as <s:button xmlns:s="something"> appear as buttons.

Expected Results:  They should not be styled at all.  default CSS styles should 
not pollute all namespaces.

see attachment

Comment 1

[hand]

Attachment: File demonstrating namespace pollution

Comment 2

[Blake Ross]

Looks like we'll need to specify an xul namespace by default for all CSS 
files.  I can do this if you want...

Comment 3

[hand]

Will that conflict with other namespaces?  eg. HTML/MathML?

Comment 4

[Pierre Saslawsky]

Reassigned to Marc like bug 53796

Comment 5

[Marc Attinasi]

I believe that is is actually a dup of bug 53796. The problem is that we are not
assigning the default namespace to some of the rules in ua.css, so they are
applying to elements in all namespaces.

*** This bug has been marked as a duplicate of 53796 ***

Comment 6

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 7

[Hixie (not reading bugmail)]

Attachment: Same testcase, sent as text/xul

Comment 8

[Hixie (not reading bugmail)]

Reopening, this is not the same issue, since pseudos are not involved.

Comment 9

[Marc Attinasi]

OK, I probably misunderstood it then. I'll look again.

Comment 10

[Marc Attinasi]

OK, I really misunderstood! 

So, is it because the XUL css files have no default namespace that the rules in 
them are applied to arbitrary namespaces? Then I think we need to take Blake up 
on his offer (from last December) to set the default namespace in all of the XUL 
css files. Blake, David, Ian? Does this sound right?

Comment 11

[Hixie (not reading bugmail)]

attinasi: Certainly *sounds* right, assuming that the XUL CSS files are in fact 
lacking the relevant @namespace rules.

Comment 12

[Marc Attinasi]

This looks like a skin-specific problem. When I use the Modern skin (which has 
default namespaces applied consistently) there is not styling of the buttons in 
the testcase. When I use the Classic skin I get the button styling in the 
testcase, probably because there is no default namespace in the css files for 
the classic skin.

* bring up testcase in Mozilla with Classic skin - note the button styling
* change to Modern skin - note the 'buttons' no longer get styled like buttons

I'm not sure what to do with this: I don't feel comfortable banging on skin 
files and I don't think there is anything 'wrong' in the style engine here... 
Should the skin owners take this and fix their css files?

Comment 13

[Marc Attinasi]

Updating summary and reassigning to skinability (not sure if that is correct 
component, but the problem is in skin CSS files).

Comment 14

[Joe Hewitt (gone)]

Blake asked me last week why I added the default namespace to every CSS file in
the Modern theme recently, and this is the reason why.  I'll take this bug and
do the same to Classic.

Comment 15

[Joe Hewitt (gone)]

Mass reassigning some of my theme bugs to Shuehan.

Comment 16

[shliang]

checked in