612568 - HTML5 fragment parser doesn't drop nsIContent handles until deleted

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Henri Sivonen (:hsivonen)]

The HTML5 parser uses nsIContent**s as handles to nodes. The allocated handle space is only freed when the tree builder is freed. In the case of a fragment parser, this means the handles are freed only once the document that has a fragment parser goes away.

In the fragment parser case, the handles should be freed after each fragment parse run.

Comment 1

[Henri Sivonen (:hsivonen)]

Nominating as a blocker, because this mean that keeping open a page like the TBPL will use up more and more memory until the tab is closed.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Drop nsIContent handles when finished parsing a fragment

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 490853 [details] [diff] [review]
Drop nsIContent handles when finished parsing a fragment

This bit really should have been part of the fix for bug 559311.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 490853 [details] [diff] [review]
Drop nsIContent handles when finished parsing a fragment

I don't think this blocks, but I have no problems with this change landing now. Approving patch.

Comment 5

[Henri Sivonen (:hsivonen)]

Thanks.

http://hg.mozilla.org/mozilla-central/rev/a74526663273