612672 - figure out how to disable mdns/zeroconf/bonjour/avahi on all slaves

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

Nov 16 13:09:37 talos-r3-fed-017 avahi-daemon[902]: Invalid query packet.
Nov 16 13:09:43 talos-r3-fed-017 avahi-daemon[902]: Invalid query packet.
Nov 16 13:09:43 talos-r3-fed-017 avahi-daemon[902]: Invalid query packet.
Nov 16 13:09:44 talos-r3-fed-017 avahi-daemon[902]: Invalid query packet.

We shouldn't have mdns/zerconf/bonjour/avahi (same protocol) services running on any of our slaves.  This protocol is used to discover local network services and is of no use to us.  Running something like '# chkconfig avahi off' should be enough on linux, but i am not sure for OS X.  Windows shouldn't have zeroconf installed.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m612672-puppet-manifests-r1.patch

Tested in staging.

The rename of 'base' to 'base-build' is to avoid falling in the same trap of thinking that 'base' is the top-level base class.  Heh.

The name 'fedora-stuff' avoids a naming conflict with the 'fedora' node.  The parallel node and class hierarchies need to be fixed up anyway, so think of this as a temporary band-aid until that works out.

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 495129 [details] [diff] [review]
m612672-puppet-manifests-r1.patch

disabling the service looks good to me, but I'd like to get Ben's thoughts on the other parts of the manifest changes

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 495129 [details] [diff] [review]
m612672-puppet-manifests-r1.patch

Hmmm, why aren't you just putting the service {} check inside of the existing talos-fedora.pp class?

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Because I want to do this on all Fedora systems, not just talos

Comment 5

[[e-mail] (:bhearsum)]

The only Fedora machines we have are test/talos ones.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

That's fine, but won't necessarily always be the case.  I can put them in the talos class for now.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 495129 [details] [diff] [review]
m612672-puppet-manifests-r1.patch

Looks good to me now.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m612672-puppet-manifests-r2.patch

This is a simpler patch with less trying-to-refactor-puppet-manifests going on

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 495917 [details] [diff] [review]
m612672-puppet-manifests-r2.patch

97d4a8bc032a