Closed Bug 612675 Opened 11 years ago Closed 11 years ago

JSTreeContext::fun/scopeChain should be private, only accessed through methods asserting consistency with JSTreeContext::flags

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch PatchSplinter Review
Accessing raw unions without asserting proper discrimination is bad.  Permitting access only through correctness-asserting accessors (with extremely narrow holes for JITs when necessary) is good.
Attachment #490971 - Flags: review?(dvander)
Attachment #490971 - Flags: review?(dvander) → review+
http://hg.mozilla.org/tracemonkey/rev/c5b733682ece
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/c5b733682ece
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.