612678 - Tab.location property should be a string

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The Tab.location property from the Tabs API is a Location object, but such objects cannot cross the process boundary.  It should be a String instead.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Morphing this bug slightly: since the value is no longer a Location object, and because we use the property name "url" for such properties in other APIs, we should use that name here as well.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

In Bug-598981 I already converted location to be a string. Once the change is in I'll rename the property name to url.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: https://github.com/mozilla/addon-sdk/pull/40

Pull request https://github.com/mozilla/addon-sdk/pull/40

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 492333 [details] [diff] [review]
https://github.com/mozilla/addon-sdk/pull/40

Looks good, works well. r=myk

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Pushed 6d53d2e