Closed Bug 612678 Opened 10 years ago Closed 10 years ago

Tab.location property should be a string

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: myk, Assigned: irakli)

References

Details

Attachments

(1 file)

The Tab.location property from the Tabs API is a Location object, but such objects cannot cross the process boundary.  It should be a String instead.
Morphing this bug slightly: since the value is no longer a Location object, and because we use the property name "url" for such properties in other APIs, we should use that name here as well.
Assignee: nobody → rFobic
In Bug-598981 I already converted location to be a string. Once the change is in I'll rename the property name to url.
Depends on: 598981
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 492333 [details] [diff] [review]
https://github.com/mozilla/addon-sdk/pull/40

Looks good, works well. r=myk
Attachment #492333 - Flags: review?(myk) → review+
Pushed 6d53d2e
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.