Closed Bug 612681 Opened 10 years ago Closed 10 years ago

Tab.thumbnail property should be a data: URI String

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: myk, Assigned: irakli)

References

Details

The Tab.thumbnail property from the Tabs API is a canvas, but such objects cannot cross the process boundary.  It should be a data: URI String instead.
Morphing this bug slightly: in addition to making it a data: URI, it should also be a getThumbnailURL method to which we can later add options for configuring the thumbnail URL returned (such as width and height) rather than a property getter to which we can never add such options.
I already converted getter so that it returns data uri in bug-598981. Once it's inn we can convert it to be a method. Passing w/h is tricky since it may not be proportional to the window size.
Assignee: nobody → rFobic
Just to be clear: I am not suggesting that we allow width and height to be passed to the getThumbnail method at this point.  I was merely using those as examples of the kinds of things we might want to do in the future.
Dietrich / Myk can one of you review this patch ? It's pretty easy so I just made a pull request.
(In reply to comment #5)
> Dietrich / Myk can one of you review this patch ? It's pretty easy so I just
> made a pull request.

r=me, thanks!
https://github.com/mozilla/addon-sdk/commit/bde4bc010869fa6bebec249dec49375c0c28a0ca
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.