612681 - Tab.thumbnail property should be a data: URI String

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The Tab.thumbnail property from the Tabs API is a canvas, but such objects cannot cross the process boundary.  It should be a data: URI String instead.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Morphing this bug slightly: in addition to making it a data: URI, it should also be a getThumbnailURL method to which we can later add options for configuring the thumbnail URL returned (such as width and height) rather than a property getter to which we can never add such options.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I already converted getter so that it returns data uri in bug-598981. Once it's inn we can convert it to be a method. Passing w/h is tricky since it may not be proportional to the window size.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Just to be clear: I am not suggesting that we allow width and height to be passed to the getThumbnail method at this point.  I was merely using those as examples of the kinds of things we might want to do in the future.

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

https://github.com/mozilla/addon-sdk/pull/38

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Dietrich / Myk can one of you review this patch ? It's pretty easy so I just made a pull request.

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to comment #5)
> Dietrich / Myk can one of you review this patch ? It's pretty easy so I just
> made a pull request.

r=me, thanks!

Comment 7

[Dietrich Ayala (:dietrich)]

https://github.com/mozilla/addon-sdk/commit/bde4bc010869fa6bebec249dec49375c0c28a0ca