Closed Bug 612758 Opened 10 years ago Closed 10 years ago

browserWindows.openWindow() should be simply open()

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: myk, Assigned: irakli)

References

()

Details

Attachments

(1 file)

The Windows API's browserWindows.openWindow() method should be simply browserWindows.open() for consistency with the Tabs API's open() function.
Assignee: nobody → rFobic
Attachment #492326 - Attachment description: Pull request → https://github.com/mozilla/addon-sdk/pull/39
Comment on attachment 492326 [details] [diff] [review]
https://github.com/mozilla/addon-sdk/pull/39

Looks good, works well, r=myk!

One nit: read only -> read-only
Attachment #492326 - Flags: review?(myk) → review+
pushed 521df7d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.