Closed
Bug 612758
Opened 15 years ago
Closed 15 years ago
browserWindows.openWindow() should be simply open()
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: myk, Assigned: irakli)
References
()
Details
Attachments
(1 file)
|
14.69 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
The Windows API's browserWindows.openWindow() method should be simply browserWindows.open() for consistency with the Tabs API's open() function.
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → rFobic
|
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #492326 -
Flags: review?(myk)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #492326 -
Attachment description: Pull request → https://github.com/mozilla/addon-sdk/pull/39
|
Reporter | |
Comment 3•15 years ago
|
||
Comment on attachment 492326 [details] [diff] [review]
https://github.com/mozilla/addon-sdk/pull/39
Looks good, works well, r=myk!
One nit: read only -> read-only
Attachment #492326 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
pushed 521df7d
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•