remove text shadows from tab text

RESOLVED FIXED in Firefox 4.0b8

Status

()

Firefox
Theme
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: jtd, Assigned: dao)

Tracking

Trunk
Firefox 4.0b8
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Tab titles are currently rendered with a text-shadow.  Especially in the case of inactive tabs where the background is darker, this leads to text that is blurry and tiring to read.  In Firefox 4 we've switched to using DirectWrite by default.  DirectWrite text rendering is much more subtle than Cleartype GDI rendering, so when a text shadow is placed on it the text tends to get washed out.

I would strongly recommend removing the text-shadow from tab title text.

Bug 594324 has a lot of background info related to this.
(Reporter)

Updated

8 years ago
Blocks: 594325
No longer blocks: 594324
(Reporter)

Comment 1

8 years ago
The first screenshot on this page also shows the problem:

https://wiki.mozilla.org/Firefox/Projects/New_Theme/Timeline

Note how the inactive tab "Bug 569255" looks washed out.
(Assignee)

Updated

8 years ago
Duplicate of this bug: 603774
(Assignee)

Updated

8 years ago
blocking2.0: --- → ?
(Assignee)

Updated

8 years ago
Blocks: 544820
(Assignee)

Comment 3

8 years ago
Created attachment 491164 [details] [diff] [review]
patch
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #491164 - Flags: ui-review?(shorlander)
Attachment #491164 - Flags: review?(gavin.sharp)
Attachment #491164 - Flags: review?(gavin.sharp) → review+
Created attachment 491671 [details]
Patch Result

This is what I get when I apply the patch.

Looks like it might be inheriting a rule:

http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser-aero.css#117
(Assignee)

Comment 5

8 years ago
Created attachment 491697 [details] [diff] [review]
patch v2

Indeed, I thought we already prevented the text shadow from being inherited, but we intentionally don't do that for personas.
Attachment #491164 - Attachment is obsolete: true
Attachment #491671 - Attachment is obsolete: true
Attachment #491697 - Flags: ui-review?(shorlander)
Attachment #491164 - Flags: ui-review?(shorlander)
Comment on attachment 491697 [details] [diff] [review]
patch v2

Looks good!
Attachment #491697 - Flags: ui-review?(shorlander) → ui-review+
(Assignee)

Updated

8 years ago
Attachment #491697 - Flags: approval2.0?
Attachment #491697 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/97b3ddd2c690
Status: ASSIGNED → RESOLVED
blocking2.0: ? → ---
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
(Reporter)

Comment 8

8 years ago
Awesome, thanks Dão!
Hmm, browser.css still has this:
  #toolbar-menubar:not(:-moz-lwtheme),
  #TabsToolbar[tabsontop="true"]:not(:-moz-lwtheme),
  #navigator-toolbox[tabsontop="false"] > #nav-bar:not(:-moz-lwtheme),
  #nav-bar + #customToolbars + #PersonalToolbar[collapsed="true"] + #TabsToolbar[tabsontop="false"]:last-child:not(:-moz-lwtheme) {
    background: transparent !important;
    color: black;
    text-shadow: 0 0 .5em white, 0 0 .5em white, 0 1px 0 rgba(255,255,255,.4);
  }

So active tab titles still have shadows.

The appmenu button also has
#appmenu-button {
  -moz-appearance: none;
  background: -moz-linear-gradient(rgb(247,182,82), rgb(215,98,10) 95%);
  background-clip: padding-box;
  border-radius: 0 0 4px 4px;
  border: 1px solid rgba(83,42,6,.9);
  border-top: none;
  box-shadow: 0 1px 0 rgba(255,255,255,.25) inset,
              0 0 0 1px rgba(255,255,255,.25) inset;
  color: white;
  text-shadow: 0 0 1px rgba(0,0,0,.7),
               0 1px 1.5px rgba(0,0,0,.5);

So it has a shadow.
(Assignee)

Comment 10

8 years ago
(In reply to comment #9)
> So active tab titles still have shadows.

I'll file a new bug on this.

> The appmenu button also has [...] So it has a shadow.

Yeah, it's supposed to have a shadow.
(Assignee)

Updated

8 years ago
Depends on: 614517
OK thanks, I just need to know which display list optimizations we're going to need for the long term :-)
You need to log in before you can comment on or make changes to this bug.