612816 - Remove some dead prefs from firefox.js

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: rm

general.startup.browser is used by suite/browser/nsBrowserContentHandler.js to determine which SeaMonkey windows to open on startup. Prior to bug 276588, xpfe's nsAppStartup::CreateStartupState would read the general.startup pref branch, and open whatever said it wanted to be opened, but we haven't actually used it since 2005 (other than the way browser/base/content/test/browser_utilityOverlay.js uses it to test getting a bool pref, but browser.search.openintab will do for a stable bool pref that testing profiles won't have any reason to change)

profile.allow_automigration was used by profile/src/nsProfile.cpp to determine whether to automatically migrate a Netscape 4.x profile, but that got the axe after 1.8

custtoolbar.personal_toolbar_folder was used by the xpfe bookmarks service, as one of three different ways to decide which bookmarks folder was the ptf, and nobody should ever have to be reminded about the xpfe bookmarks service

Comment 1

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/3f34857aafdb

Comment 2

[Vlad [QA]]

Verified on Mozilla/5.0 (Windows NT 6.1; rv:2.2a1pre) Gecko/20110403 Firefox/4.2a1pre

The following prefs have been removed:

general.startup.browser
profile.allow_automigration
custtoolbar.personal_toolbar_folder

Comment 3

[:aceman]

I have seen discussions that profile.allow_automigration also controls importing IE settings into FF. Is that no longer the case?
And what about profile.confirm_automigration ?