Keep recent replies in database

VERIFIED FIXED in 2.3.2

Status

support.mozilla.org
Army of Awesome
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: williamr, Assigned: wenzel)

Tracking

unspecified
2.3.2

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

7 years ago
Once a user submits a reply on the page, add that reply to the database so we can show it on the page for other users. We'll probably want a separate table for storing these replies.

We specifically need to track the in_reply_to_status ID for these replies in addition to the user, tweet text, timestamp, and tweet ID.

Also, only replies from the last 24-48 hours need to be kept in the database so older replies should be removed. Should we set this up as a cronjob?

Just for reference, this mockup shows how the replies will be shown. A separate bug will track the frontend changes.

http://people.mozilla.com/~williamr/communitycare/mockups/armyofawesome_231a.jpg
(Assignee)

Comment 1

7 years ago
I am now saving the outgoing tweet data in a format similar to what the collected tweets look like in the database:

https://github.com/fwenzel/kitsune/compare/master...cc-keep-replies-612931

Old replies get removed from the database in the same cron job that new tweets are collected. The process is somewhat fuzzy to keep it simple but as a rule of thumb, when a collected tweet is dropped from the database, its replies also go away.

Likewise, we won't remove replies for a collected tweet as long as it stays in the database.

jsocol: r?
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 years ago
jsocol r+ed this, it landed here:
https://github.com/jsocol/kitsune/commit/7158f9c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: 2.3.1 → 2.3.2
Verified replies removed with old tweets
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.