612943 - Show/hide replies when clicking on number of replies for a tweet

Status: VERIFIED FIXED

(support.mozilla.org :: Army of Awesome, task)

Description

[William Reynolds [:williamr]]

Show replies to tweets on the page when a user clicks on the original tweet's number of replies (eg: they click on "You replied" or "dailycavalier and 1 other replied").

These replies are indented 1 level only and appear beneath the original tweet. Clicking on the number of replies again will hide the replies. When toggling the showing/hiding of replies, we should use the same sliding animation that we use with toggling categories in the reply window dialog.

This mockup shows the styling:
http://people.mozilla.com/~williamr/communitycare/mockups/armyofawesome_231a.jpg

Like the other tweets, these replies can also be replied to by signed in users. 

The replies can be either hidden elements that becomes visible when toggled or be loaded in an AJAX request to retrieve the reply data from the database.

Comment 1

[Fred Wenzel [:wenzel]]

https://github.com/fwenzel/kitsune/compare/master...cc-list-responses-612935

This patch shows all replies that we have in the database alongside their parent tweets, and shows/hides them on click.

I don't display names yet -- that's bug 612935.

jsocol: r?

Comment 2

[Fred Wenzel [:wenzel]]

One thing I just noticed is the sliding vs. fading animation. I'll fix this, but please go ahead and review the patch anyway.

Comment 3

[Fred Wenzel [:wenzel]]

Finally, please note that currently, the entire reply tree under a tweet is indented only once (i.e. the reply tree is "flat"). This is so we don't out of horizontal space once we reach several levels of indentation. This only affects indentation: The different levels slide out separately when clicking on the respective reply count.

If this is not what you want, please speak up, or file an enhancement during QA.

Comment 4

[Fred Wenzel [:wenzel]]

Showing/hiding responses to tweets landed here:
https://github.com/jsocol/kitsune/commit/e471008

(with indentation fixes and sliding instead of fading).


James also had me add a global "kill switch" for the slightly database-intensive "show all replies recursively" code, which landed here:
https://github.com/jsocol/kitsune/commit/1013db8

Comment 5

[Rebecca Billings [:rbillings]]

Verified link for 'you replied' or 'username replied', slides open, displays one indent deep