613021 - Don't make an element invalid if the value length is higher than the maxlength value

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

It broke compatibility given that maxlength was available in HTML4 and some websites set the value .value.

This should block given that some forms are broken.

This is going to be reverted in Firefox 4 with these bugs: bug 613016 and bug 613019

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Blocking since this is breaking websites.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

This patch also prevent maxlength from making textarea invalid even if the retro-compat is probably less touchy for textarea's (maxlength wasn't working in 3.6 with textarea's, it has been added with HTML5 specs).

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Please send a comment to the list making it clear in no uncertain terms that we don't consider it compatible with the web to enforce length checks on script-set values and so we won't implement it.

Comment 4

[Mounir Lamouri (:mounir)]

Sure, it was planned. I just need to take the time to explain our plan.

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/77d32c00769c

Comment 6

[Eric Shepherd [:sheppy]]

Not sure what needs documenting here. I recognize there's a behavior change, but it sounds like we're just reverting it to work the way it did before, and it's a subtlety that's not documented.

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to comment #6)
> Not sure what needs documenting here. I recognize there's a behavior change,
> but it sounds like we're just reverting it to work the way it did before, and
> it's a subtlety that's not documented.

Indeed, https://developer.mozilla.org/en/DOM/ValidityState hasn't been done yet so I guess this doesn't need dev-doc but that means bug 345624 wasn't fully documented.

Comment 8

[Eric Shepherd [:sheppy]]

ValidityState is documented, it's just got a weird name. I've renamed the page. But I still am not clear on what needs documenting here, from a developer standpoint. https://developer.mozilla.org/en/DOM/ValidityState

Comment 9

[Mounir Lamouri (:mounir)]

(In reply to comment #8)
> ValidityState is documented, it's just got a weird name. I've renamed the page.
> But I still am not clear on what needs documenting here, from a developer
> standpoint. https://developer.mozilla.org/en/DOM/ValidityState

tooLong can never be true because an element can't suffer from being too long now.

Comment 10

[Eric Shepherd [:sheppy]]

OK, now I see. I've added a note to that effect. Thanks for your patient explanation.

Comment 11

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)