613068 - Structured clone read functions should have an extra "version" argument

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We need to be able to deserialize buffers that were encoded with an older version of the structured clone writer, keyed off of JS_STRUCTURED_CLONE_VERSION (defined in jsapi.h). If we always maintain backwards compatibility this shouldn't be too much trouble.

Comment 1

[Johnny Stenback (:jst)]

Blocking, as this blocks blocker bug 613083.

Comment 2

[David Mandelin [:dmandelin]]

Who would be a good candidate to work on this? Is this a JS bug, or is it more of a content bug?

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I think jorendorff wants this one.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: v1

This should get us off the ground. JS_WriteStructuredClone could have a matching out-param, if we care, but I think the macro is just as good for our purposes.

I don't expect we'll need to write old formats, so I don't think JS_WriteStructuredClone needs a version in-param. Let me know if you think otherwise.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 493072 [details] [diff] [review]
v1

Looks great! r=me.

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/ad4b7fa4e68d