613082 - test-e10s.testRemoteException fails after latest tracemonkey merge

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The test-e10s.testRemoteException test function fails on a tip build I just built after the most recent merge from tracemonkey to mozilla-central <http://hg.mozilla.org/mozilla-central/rev/78a42f77bb90> (and the followup change to fix bustage caused by the merge <http://hg.mozilla.org/mozilla-central/rev/35f8ec6fa9e6>):

--------------------------------------------------------------------------------
error: TEST FAILED: test-e10s.testRemoteException (failure)
error: fail: "[\"exception\",\"Error: uncaught exception: Error: alas\"]" != "[\"exception\",\"Error: alas\"]"
info: Traceback (most recent call last):
  File "resource://testpkgs-jetpack-core-lib/errors.js", line 49, in null
    return callback.apply(this, arguments);
  File "resource://testpkgs-jetpack-core-lib/e10s.js", line 140, in null
    console.exception(remoteException(exception));
  File "resource://testpkgs-jetpack-core-tests/test-e10s.js", line 46, in null
    addAction(["exception", ex.toString()]);
  File "resource://testpkgs-jetpack-core-tests/test-e10s.js", line 29, in addAction
    test.assertEqual(JSON.stringify(action), JSON.stringify(expected));
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 195, in assertEqual
    this.fail(message);
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 113, in fail
    console.trace();
--------------------------------------------------------------------------------

The function doesn't fail on the latest nightly build, so the change that broke the test must have landed in the last day.  I don't know for sure that the tracemonkey merge is the culprit, but it does seem the most likely candidate.

In any case, the failure seems trivial to resolve by updating the test to reflect the new syntax.  But before we do that, though, we should verify that the change is intentional.

sayrer: can you confirm that?

Comment 1

[Atul Varma [:atul]]

Fixed:

https://github.com/mozilla/addon-sdk/commit/a9e20bf90f403f94d427fe9fe1d7e93ee97d0c71