Esc key should cancel Forget tab in Data Manager

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Passwords & Permissions
--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Robert Kaiser)

Tracking

Trunk
seamonkey2.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Steps to reproduce
1. Select a domain
2. Press delete key
3. Forget tab appears

Only way to get rid of the forget tab at the moment is to switch to another domain, would be good to have the Esc key get rid of it too.
(Assignee)

Comment 1

7 years ago
Created attachment 493520 [details] [diff] [review]
v1: escape from the forget panel on ESC

This patch should do it for the common cases. As the panel itself can't be focused, we actually need to capture keypress events on those elements that have focus, like the domain tree or the forget tab. In the case that we have done a successful forget of all data in the domain, we don't have focus on anything, so the event goes to the window, and we also don't have a domain selected, so we need to go and select one to hide the panel (I chose to just use the first in the list). In other cases, we can perform a select on the current domain, which will go to the first available panel of that domain and hide forget.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #493520 - Flags: review?(iann_bugzilla)
(Reporter)

Updated

7 years ago
Attachment #493520 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 2

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/573786da52d7
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in before you can comment on or make changes to this bug.