613091 - js/src/jsdbgapi.cpp:1424:16: warning: converting to non-pointer type ‘JSBool’ from NULL

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

> js/src/jsdbgapi.cpp: In function ‘JSBool JS_EvaluateUCInStackFrame(JSContext*, JSStackFrame*, const jschar*, uintN, const char*, uintN, jsval*)’:
> js/src/jsdbgapi.cpp:1424:16: warning: converting to non-pointer type ‘JSBool’ from NULL

Looks like we're intending to return "false" (or JS_FALSE) there.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 491391 [details] [diff] [review]
trivial fix

Thanks for catching this.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 491391 [details] [diff] [review]
trivial fix

No problem, thanks for the quick review! :)

Requesting approval to land.

Comment 4

[Jeff Walden [:Waldo]]

Yesterday morning I got fed up with all the 4.5-only (?) warnings I've been getting for a couple weeks, and I pushed fixes for all of them to the TM repository:

http://hg.mozilla.org/tracemonkey/rev/0c72e1963839
http://hg.mozilla.org/tracemonkey/rev/2e440dc69d19

One of those fixes included this bug's complaint.  So this bug is fixed in the TraceMonkey repository, and in the mozilla-central repository as of today's merge, but not by this bug's effort.  :-\  Sorry for the duplication of effort...

Comment 5

[Daniel Holbert [:dholbert]]

No prob, thanks for fixing. :)