613092 - Method "addScript" in jsdbgapi.cpp returns JS_FALSE instead of a pointer value

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

>    EthogramScriptEntry *addScript(JSContext *cx, JSObject *obj, char *filename, JSString *jsfilename) {
>        JSHashNumber hash = JS_HashString(filename);
>        JSHashEntry **hep = JS_HashTableRawLookup(traceVisScriptTable, hash, filename);
>        if (*hep != NULL)
>            return JS_FALSE;
http://hg.mozilla.org/mozilla-central/annotate/tip/js/src/jsdbgapi.cpp#l2222

We should probably be returning NULL there.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 491390 [details] [diff] [review]
fix

Requesting approval.

No functional change -- just returning null instead of false, to fix a build warning.

Comment 3

[Daniel Holbert [:dholbert]]

actually I don't think there was a build warning in this case -- so, this is just a technical-correctness fix. (returning a zero pointer-value instead of a zero boolean value)

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 491390 [details] [diff] [review]
fix

ah, and gavin reminds me that this should land on tracemonkey, not mozilla-central.  Canceling approval2.0 request.

Comment 5

[Daniel Holbert [:dholbert]]

Landed on tracemonkey: http://hg.mozilla.org/tracemonkey/rev/e852f9426d25

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/e852f9426d25