Closed
Bug 613118
Opened 15 years ago
Closed 15 years ago
WM_SYSCOMMAND doesn't properly filter wParam
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jimm, Assigned: jimm)
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
robarnold
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
According to MSDN:
"In WM_SYSCOMMAND messages, the four low-order bits of the wParam parameter are used internally by the system. To obtain the correct result when testing the value of wParam, an application must combine the value 0xFFF0 with the wParam value by using the bitwise AND operator."
|
Assignee | |
Updated•15 years ago
|
Attachment #491429 -
Flags: review?(tellrob)
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → jmathies
|
||
Comment 1•15 years ago
|
||
Comment on attachment 491429 [details] [diff] [review]
patch
Was this just you noticing we weren't following the spec or was there some buggy behavior you saw?
Attachment #491429 -
Flags: review?(tellrob) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Comment on attachment 491429 [details] [diff] [review]
> patch
>
> Was this just you noticing we weren't following the spec or was there some
> buggy behavior you saw?
Just noticed it, everything appears to be working fine for the commands we test for.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #491429 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #491429 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•