role nothing should allow recursive name calculation from children

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
Disability Access APIs
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla2.0b8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

24.03 KB, patch
Fernando Herrera
: review+
MarcoZ
: review+
davidb
: review+
davidb
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
The role nothing should be transparent for name calculation recursion, it's just container that we nothing about it. It should be similar to text containers like paragraphs in this case - just look inside.

The affect of eNoRule for role nothing can be seen on dojo dropdown button menus, where NVDA does announce only group information of menuitem when you traverse through menuitems.
(Assignee)

Comment 1

7 years ago
Created attachment 491455 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Attachment #491455 - Flags: review?(marco.zehe)
Attachment #491455 - Flags: review?(fherrera)
Attachment #491455 - Flags: approval2.0?

Comment 2

7 years ago
Same with orca. Without the patach it only speaks "menuitem" while traversing items and with the patch it speaks "menuitem 1" and "menuitem 2"
Comment on attachment 491455 [details] [diff] [review]
patch

[r=me] I'll wait for reviewers before approval (I didn't check the tests).

> PRUint32 nsTextEquivUtils::gRoleToNameRulesMap[] =
> {
>-  eNoRule,           // ROLE_NOTHING
>+  eFromSubtreeIfRec, // ROLE_NOTHING


Seems right, since we can't assume ROLE_NOTHING is a dead end while recursing for a name.
Attachment #491455 - Flags: review+

Comment 4

7 years ago
Comment on attachment 491455 [details] [diff] [review]
patch

r=me. Thanks also for reorganizing them into the separate folder!
Attachment #491455 - Flags: review?(marco.zehe) → review+
Comment on attachment 491455 [details] [diff] [review]
patch

Approved.
Attachment #491455 - Flags: approval2.0? → approval2.0+

Comment 6

7 years ago
Comment on attachment 491455 [details] [diff] [review]
patch

r=me

sorry for been late here :)
Attachment #491455 - Flags: review?(fherrera) → review+
(Assignee)

Comment 7

7 years ago
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/a54bdb8efa9d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Depends on: 613828
You need to log in before you can comment on or make changes to this bug.