613147 - [SeaMonkey] mochitest-plain-1: new test fails = "test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it"

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Serge Gautherie (:sgautherie)]

3-platform t-b:
{
36806 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
36807 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad - got 15, expected 0
}


(Fwiw, this is the last 3-platform SeaMonkey perma-orange for this suite...)

Comment 1

[Markus Stange [:mstange]]

Attachment: set the zoom pref

This might fix it. Is there any way I can test it?

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 492365 [details] [diff] [review]
set the zoom pref

(In reply to comment #1)
> This might fix it. Is there any way I can test it?

(Download build and tests then apply patch manually.)

>+  prefSvc.setBoolPref("mousewheel.withcontrolkey.action", 3);

with s/setBoolPref/setIntPref/, this patch fixes the test on my local Windows 2000 :-)

Additional nits:
*Using http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/mozprefs.js#51 pref() would be even better.
*s/SimpleTest.finish()/SimpleTest.executeSoon(SimpleTest.finish)/ with a comment, as there is |setTimeout(nextTest, 0);|,
 see http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/SimpleTest.js#780

Thanks.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> *s/SimpleTest.finish()/SimpleTest.executeSoon(SimpleTest.finish)/ with a
> comment

To be explicit: "// finish(), yet let the test actually end first, to be safe."

Comment 4

[Markus Stange [:mstange]]

Pushed with setIntPref, thanks for the catch:
http://hg.mozilla.org/mozilla-central/rev/118d61cdfb06

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1291046976.1291049978.4891.gz
Linux comm-central-trunk debug test mochitests-1/5 on 2010/11/29 08:09:36
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1291049972.1291053200.18616.gz
OS X 10.5 comm-central-trunk debug test mochitests-1/5 on 2010/11/29 08:59:32
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1291047565.1291050294.6341.gz
OS X 10.6 comm-central-trunk debug test mochitests-1/5 on 2010/11/29 08:19:25
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1291052806.1291055371.28156.gz
WINNT 5.2 comm-central-trunk debug test mochitests-1/5 on 2010/11/29 09:46:46

V.Fixed

Comment 6

[Legacy TBPL/Treeherder Robot]

sgautherie
https://tbpl.mozilla.org/php/getParsedLog.php?id=8373225&tree=Firefox
Rev3 WINNT 5.1 mozilla-central opt test mochitests-1/5 on 2012-01-06 05:22:37

47881 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad - didn't expect 1, but got it
47899 ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_bug607464.html | Pixel scrolling should have finished after waiting for one 0-interval timer. We shouldn't be scrolling smoothly, even though the pref is set. - got 13, expected 15