Closed Bug 613194 Opened 16 years ago Closed 16 years ago

Fix some JS errors we see in the browser-chrome tests

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patch — — Splinter Review
These errors are likely due to the speed at which the tests are running. Things are happening faster than manually using the application. ----------------- JavaScript Error: "self.control is undefined" {file: "chrome://browser/content/bindings.xml" line: 690} The control is going away before the timeout has a chance to complete so we need to check for a valid control, even though we already did before calling the setTimeout. ----------------- JavaScript Error: "this._list is null" {file: "chrome://browser/content/browser-ui.js" line: 2305} We need to put some checks in place for situations where the list could have been reset ----------------- JavaScript Error: "aTab.thumbnail is undefined" {file: "chrome://browser/content/tabs.xml" line: 139} The tab is going away before the image onload event is finished so we need to check for the tab thumbnail
Attachment #491510 - Flags: review?(21)
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
VERIFIED FIXED on: Build Id:Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110530 Firefox/7.0a1 Fennec/7.0a1 Build Id:Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110530 Firefox/6.0a2 Fennec/6.0a2
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: