Closed Bug 613198 Opened 14 years ago Closed 14 years ago

Changing the "No Proxy for" list UI from a textbox to a textarea

Categories

(SeaMonkey :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 3 obsolete files)

Currently, both in 2.0.10 and 2.1b2pre the "No Proxy" list is a textbox widget. That being the case, entering more than 4 or 5 hosts (depending on length of each host name) it will need scrolling. Changing this to a textarea will allow the user the ability to easily view the previous host entries. Right now, the 'no proxy for' list is a comma-delimited entry. Optionally changing the format of the entries to a line based entry might be easier on the eyes.
Summary: Changing the No Proxy list from a textbox to a textarea → Changing the "No Proxy for" list UI from a textbox to a textarea
textarea sounds promising but I'd keep with comma-delimited entries.
Hardware: x86 → All
Version: unspecified → Trunk
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #501936 - Flags: review?(iann_bugzilla)
Comment on attachment 501936 [details] [diff] [review] Changed the No Proxy textbox to multiline textbox. Looks good to me, I don't think it has any css or os x implications, so should be ready to checkin.
Attachment #501936 - Flags: review?(iann_bugzilla) → review+
Attachment #501936 - Flags: ui-review?(neil)
I'm not 100% convinced by the alignment of the label: +-------------------------------------+ |localhost, 127.0.0.1 | No Proxy For: | | | | +-------------------------------------+ <row align="baseline"> seems to give a more pleasing effect. Ian? [Note to self: access keys on the labels aren't working?]
(In reply to comment #4) > [Note to self: access keys on the labels aren't working?] [Buggy build. Three other builds are OK.]
(In reply to comment #4) > I'm not 100% convinced by the alignment of the label: > +-------------------------------------+ > |localhost, 127.0.0.1 | > No Proxy For: | | > | | > +-------------------------------------+ > <row align="baseline"> seems to give a more pleasing effect. Ian? Agreed.
Changed align="center" to align="baseline" as per comment #5.
Attachment #501936 - Attachment is obsolete: true
Attachment #502725 - Flags: ui-review?(neil)
Attachment #502725 - Flags: review+
Attachment #501936 - Flags: ui-review?(neil)
(In reply to comment #7) > Created attachment 502725 [details] [diff] [review] > Changed the No Proxy textbox to multiline textbox. > > Changed align="center" to align="baseline" as per comment #5. Actually comment #5 said <row align="baseline"> ...
Sorry, I forgot to describe the effect I was looking for, which is this: +-------------------------------------+ No Proxy For: |localhost, 127.0.0.1 | | | | | +-------------------------------------+
Attachment #502725 - Attachment is obsolete: true
Attachment #502765 - Flags: ui-review?(neil)
Attachment #502765 - Flags: review+
Attachment #502725 - Flags: ui-review?(neil)
Comment on attachment 502765 [details] [diff] [review] Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox >- <row align="center"> >+ <row align="baseline"> Nit: As you're changing this line anyway, you could remove the trailing space.
Attachment #502765 - Flags: ui-review?(neil) → ui-review+
Fixed trailing space nit.
Attachment #502765 - Attachment is obsolete: true
Attachment #502768 - Flags: ui-review+
Attachment #502768 - Flags: review+
Keywords: checkin-needed
Comment on attachment 502768 [details] [diff] [review] Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox [Checkin: comment 13] http://hg.mozilla.org/comm-central/rev/533a76b1095a
Attachment #502768 - Attachment description: Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox → Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox [Checkin: comment 13]
Keywords: checkin-needed
Target Milestone: --- → seamonkey2.1b2
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 783600
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: